From: Christian Brauner <christian.brauner@ubuntu.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
James Morris <jamorris@linux.microsoft.com>,
Serge Hallyn <serge@hallyn.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] posix-acl: avoid -Wempty-body warning
Date: Mon, 22 Mar 2021 14:21:03 +0100 [thread overview]
Message-ID: <20210322132103.qiun2rjilnlgztxe@wittgenstein> (raw)
In-Reply-To: <20210322131402.3117465-1-arnd@kernel.org>
On Mon, Mar 22, 2021 at 02:13:59PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The fallthrough comment for an ignored cmpxchg() return value
> produces a harmless warning with 'make W=1':
>
> fs/posix_acl.c: In function 'get_acl':
> fs/posix_acl.c:127:36: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 127 | /* fall through */ ;
> | ^
>
> Simplify it as a step towards a clean W=1 build. As all architectures
> define cmpxchg() as a statement expression these days, it is no longer
> necessary to evaluate its return code, and the if() can just be droped.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks you!
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
prev parent reply other threads:[~2021-03-22 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 13:13 Arnd Bergmann
2021-03-22 13:21 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322132103.qiun2rjilnlgztxe@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jamorris@linux.microsoft.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®