From: Stephen Boyd <swboyd@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>,
Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>
Subject: [PATCH v2 11/12] buildid: Fix kernel-doc notation
Date: Tue, 23 Mar 2021 19:04:42 -0700 [thread overview]
Message-ID: <20210324020443.1815557-12-swboyd@chromium.org> (raw)
In-Reply-To: <20210324020443.1815557-1-swboyd@chromium.org>
Kernel doc should use "Return:" instead of "Returns" to properly reflect
the return values.
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Jessica Yu <jeyu@kernel.org>
Cc: Evan Green <evgreen@chromium.org>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
lib/buildid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/buildid.c b/lib/buildid.c
index 1a35b28a85d8..f797e4439bda 100644
--- a/lib/buildid.c
+++ b/lib/buildid.c
@@ -120,7 +120,7 @@ static int get_build_id_64(const void *page_addr, unsigned char *build_id,
* @build_id: buffer to store build id, at least BUILD_ID_SIZE long
* @size: returns actual build id size in case of success
*
- * Returns 0 on success, otherwise error (< 0).
+ * Return: 0 on success, -EINVAL otherwise
*/
int build_id_parse(struct vm_area_struct *vma, unsigned char *build_id,
__u32 *size)
--
https://chromeos.dev
next prev parent reply other threads:[~2021-03-24 2:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 2:04 [PATCH v2 00/12] Add build ID to stacktraces Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 01/12] buildid: Add API to parse build ID out of buffer Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 02/12] buildid: Add method to get running kernel's build ID Stephen Boyd
2021-03-24 9:24 ` Rasmus Villemoes
2021-03-24 19:06 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 03/12] dump_stack: Add vmlinux build ID to stack traces Stephen Boyd
2021-03-24 11:22 ` Andy Shevchenko
2021-03-24 19:01 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces Stephen Boyd
2021-03-24 9:57 ` Rasmus Villemoes
2021-03-24 19:11 ` Stephen Boyd
2021-03-24 22:21 ` Rasmus Villemoes
2021-03-24 22:28 ` Stephen Boyd
2021-03-30 10:51 ` Petr Mladek
2021-03-30 10:29 ` Petr Mladek
2021-03-30 19:12 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 05/12] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 06/12] x86/dumpstack: " Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 07/12] scripts/decode_stacktrace.sh: Support debuginfod Stephen Boyd
2021-03-24 11:27 ` Andy Shevchenko
2021-03-24 22:22 ` Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 08/12] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 09/12] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path Stephen Boyd
2021-03-24 2:04 ` [PATCH v2 10/12] buildid: Mark some arguments const Stephen Boyd
2021-03-24 2:04 ` Stephen Boyd [this message]
2021-03-24 2:04 ` [PATCH v2 12/12] kdump: Use vmlinux_build_id() to simplify Stephen Boyd
2021-03-24 8:55 ` [PATCH v2 00/12] Add build ID to stacktraces Christoph Hellwig
2021-03-25 11:06 ` peter enderborg
2021-03-25 23:21 ` Stephen Boyd
2021-03-30 10:59 ` Petr Mladek
[not found] ` <32011616573677@mail.yandex-team.ru>
2021-03-24 19:04 ` Stephen Boyd
2021-03-25 11:14 ` peter enderborg
2021-03-25 23:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324020443.1815557-12-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=evgreen@chromium.org \
--cc=hsinyi@chromium.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®