From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A12CFC433E3 for ; Wed, 24 Mar 2021 02:05:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8234C61A2A for ; Wed, 24 Mar 2021 02:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234766AbhCXCFJ (ORCPT ); Tue, 23 Mar 2021 22:05:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234729AbhCXCEy (ORCPT ); Tue, 23 Mar 2021 22:04:54 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F7C1C0613D8 for ; Tue, 23 Mar 2021 19:04:54 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id ay2so7100990plb.3 for ; Tue, 23 Mar 2021 19:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xySi1eigssqYWy/eI4nZqzgttEYEQuYi6sWqKVX3Vec=; b=i06PGAqKhKGnGL6DOprRHrG8cbw57RqexRyr7W1bsK6A2cQoC6Seb3phQYzeeD3Tpc qylhS9HcMt+GntxZmYAegSC7WQwPzogsxoKARTxRcBVffCxWf/lh8GyCc62vEJCEo/Ga RR9pzYJIJtwRbfUD6Y42AVWruzwO3qQXt/l2I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xySi1eigssqYWy/eI4nZqzgttEYEQuYi6sWqKVX3Vec=; b=GYO0kYDOjVSDr09MzIxItban3c+ZXeamtJbLzD6ocsOYUbZeozRxGoY2ecwgkCibAv H9jl0UiBe0/Wa9iqzbXpPmojpR6zTZ6TKdXvdyhidPwbmuiu5EciXLd5E4xxYtTJEXoa UG9aeY3V/o8W3a31MwI7DXNcW+Y/1utv7tvNrRmLwfLTE1R9R7znZHfTyl6bWv8F//J+ 7sq+xRa1QFhp7kpFbrMg5MTr1BbWlYvHVGbpt0GYPyVAF+YZIYFKfr17y1GFkAM1Vzf4 ozHBBJOouktsfsYcpRM7aOOP3qKmRQzEoRYcHHe/Yn3qLas8LXMS5W9U6dRsXgSDAxSF yDIg== X-Gm-Message-State: AOAM530JajYv2cGTbfwiXjxJioP6IfmKvi9pqP4wIqGpn3P6MZSEKRra tfonsy6PP7yvYm4xsmMEdWG43g== X-Google-Smtp-Source: ABdhPJz4UpE4ksB09Ayuuf7HNSQXgsf6F0yQO+3RbRtsuQxUUJlLyQxrQhf5+GWyX/CcXGVPYN/bcA== X-Received: by 2002:a17:90b:291:: with SMTP id az17mr921631pjb.206.1616551494041; Tue, 23 Mar 2021 19:04:54 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:84ac:62f7:16a8:ccc7]) by smtp.gmail.com with ESMTPSA id b3sm389441pjg.41.2021.03.23.19.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 19:04:53 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Andy Shevchenko , Matthew Wilcox Subject: [PATCH v2 06/12] x86/dumpstack: Use %pSb for backtrace printing Date: Tue, 23 Mar 2021 19:04:37 -0700 Message-Id: <20210324020443.1815557-7-swboyd@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog In-Reply-To: <20210324020443.1815557-1-swboyd@chromium.org> References: <20210324020443.1815557-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Matthew Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- arch/x86/kernel/dumpstack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index 299c20f0a38b..7ad5eea99b2b 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -143,9 +143,9 @@ void show_opcodes(struct pt_regs *regs, const char *loglvl) void show_ip(struct pt_regs *regs, const char *loglvl) { #ifdef CONFIG_X86_32 - printk("%sEIP: %pS\n", loglvl, (void *)regs->ip); + printk("%sEIP: %pSb\n", loglvl, (void *)regs->ip); #else - printk("%sRIP: %04x:%pS\n", loglvl, (int)regs->cs, (void *)regs->ip); + printk("%sRIP: %04x:%pSb\n", loglvl, (int)regs->cs, (void *)regs->ip); #endif show_opcodes(regs, loglvl); } -- https://chromeos.dev