From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B8AC433E1 for ; Wed, 24 Mar 2021 14:54:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDE9361A19 for ; Wed, 24 Mar 2021 14:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236326AbhCXOxz (ORCPT ); Wed, 24 Mar 2021 10:53:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:43370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236398AbhCXOxP (ORCPT ); Wed, 24 Mar 2021 10:53:15 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8466561A10; Wed, 24 Mar 2021 14:53:14 +0000 (UTC) Date: Wed, 24 Mar 2021 10:53:13 -0400 From: Steven Rostedt To: Guenter Roeck Cc: Jisheng Zhang , Jens Wiklander , linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints Message-ID: <20210324105313.4ff3ad07@gandalf.local.home> In-Reply-To: <20210324144853.GA5718@roeck-us.net> References: <20210210144409.36ecdaed@xhacker.debian> <20210324143407.GA8717@roeck-us.net> <20210324144853.GA5718@roeck-us.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Mar 2021 07:48:53 -0700 Guenter Roeck wrote: > On Wed, Mar 24, 2021 at 07:34:07AM -0700, Guenter Roeck wrote: > > On Wed, Feb 10, 2021 at 02:44:09PM +0800, Jisheng Zhang wrote: > > > Add tracepoints to retrieve information about the invoke_fn. This would > > > help to measure how many invoke_fn are triggered and how long it takes > > > to complete one invoke_fn call. > > > > > > Signed-off-by: Jisheng Zhang > > > > arm64:defconfig: > > > > make-arm64 -j drivers/tee/optee/call.o > > CALL scripts/atomic/check-atomics.sh > > CALL scripts/checksyscalls.sh > > CC drivers/tee/optee/call.o > > In file included from drivers/tee/optee/optee_trace.h:67, > > from drivers/tee/optee/call.c:18: > > ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory > > 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) > > | ^ > > compilation terminated. > > > > The problem also affects arm:imx_v6_v7_defconfig. > I think it affects everything. The problem is that the drivers/tee/optee/Makefile needs to be updated with: CFLAGS_call.o := -I$(src) otherwise the compiler wont know how to find the path to optee_tree.h. This is described in: samples/trace_events/Makefile -- Steve