From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C8FDC433E4 for ; Wed, 24 Mar 2021 18:25:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D5A661A0E for ; Wed, 24 Mar 2021 18:25:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237532AbhCXSYq (ORCPT ); Wed, 24 Mar 2021 14:24:46 -0400 Received: from mga09.intel.com ([134.134.136.24]:16715 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237298AbhCXSYZ (ORCPT ); Wed, 24 Mar 2021 14:24:25 -0400 IronPort-SDR: u0BXAHGzOwwtHi+J0WuD0hauc5P3vEw3lxRRv8ZSlpY/zLLge78r0pxCyli4dCNRDgnxVumjOK +2tDcyNNJ+yw== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="190857221" X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="190857221" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 11:24:23 -0700 IronPort-SDR: H8fKkRDL6KDXqfGvIm5i/rDyWLDoiuYZ4U3ghKa7SfHZ8PkFVBZolHrPcKfXz3YJPYnLU4gbQW lA14730w3S1A== X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="408967340" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 11:24:23 -0700 Date: Wed, 24 Mar 2021 11:24:22 -0700 From: Ira Weiny To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , x86@kernel.org, Sean Christopherson , Jethro Beekman , Jarkko Sakkinen , Dave Hansen , Dave Hansen , linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init() Message-ID: <20210324182422.GU3014244@iweiny-DESK2.sc.intel.com> References: <20210306002058.303796-1-ira.weiny@intel.com> <20210324094720.GA5010@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324094720.GA5010@zn.tnic> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 10:47:20AM +0100, Borislav Petkov wrote: > On Fri, Mar 05, 2021 at 04:20:58PM -0800, ira.weiny@intel.com wrote: > > > Subject: Re: [PATCH v5] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init() > > The tip tree preferred format for patch subject prefixes is > 'subsys/component:', e.g. 'x86/apic:', 'x86/mm/fault:', 'sched/fair:', > 'genirq/core:'. Please do not use file names or complete file paths as > prefix. 'git log path/to/file' should give you a reasonable hint in most > cases. Fixed. > > > From: Ira Weiny > > > > kmap is inefficient and we are trying to reduce the usage in the kernel. > > Please use passive voice in your commit message: no "we" or "I", etc, > and describe your changes in imperative mood. > > Also, pls read section "2) Describe your changes" in > Documentation/process/submitting-patches.rst for more details. > > Bottom line is: personal pronouns are ambiguous in text, especially with > so many parties/companies/etc developing the kernel so let's avoid them > please. Fixed. > > > @@ -615,11 +614,14 @@ static long sgx_ioc_enclave_init(struct sgx_encl *encl, void __user *arg) > > if (copy_from_user(&init_arg, arg, sizeof(init_arg))) > > return -EFAULT; > > > > - initp_page = alloc_page(GFP_KERNEL); > > - if (!initp_page) > > + /* > > + * sigstruct must be on a page boundry and token on a 512 byte boundry > > + * kmalloc() gives us this alignment when allocating PAGE_SIZE bytes > > Please integrate scripts/checkpatch.pl into your patch creation > workflow. Some of the warnings/errors *actually* make sense. > > WARNING: 'boundry' may be misspelled - perhaps 'boundary'? > #90: FILE: arch/x86/kernel/cpu/sgx/ioctl.c:618: > + * sigstruct must be on a page boundry and token on a 512 byte boundry > ^^^^^^^ > > WARNING: 'boundry' may be misspelled - perhaps 'boundary'? > #90: FILE: arch/x86/kernel/cpu/sgx/ioctl.c:618: > + * sigstruct must be on a page boundry and token on a 512 byte boundry > ^^^^^^^ > > Also, do you see how other comments in this file are proper sentences? > Please formulate yours this way too. Thanks fixed. > > The change itself looks ok. Thanks, new version 5 sent. Ira > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette