From: Steven Rostedt <rostedt@goodmis.org>
To: Li Huafei <lihuafei1@huawei.com>
Cc: <mingo@redhat.com>, <jolsa@redhat.com>,
<linux-kernel@vger.kernel.org>, <yangjihong1@huawei.com>,
<xukuohai@huawei.com>, <zhangjinhao2@huawei.com>
Subject: Re: [PATCH 2/2] perf, ftrace: Fix use-after-free in __ftrace_ops_list_func()
Date: Wed, 24 Mar 2021 21:14:55 -0400 [thread overview]
Message-ID: <20210324211455.35beb1e2@oasis.local.home> (raw)
In-Reply-To: <20210324211123.64d72c02@oasis.local.home>
On Wed, 24 Mar 2021 21:11:23 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> And what you are saying is that we are not getting there, where the
> dynamically allocated perf ops is not set to be DYNAMIC?
>
> That should be set as DYNAMIC if the ops was allocated, and can later
> be freed. This code was written specifically to handle perf.
>
> Thus, NACK on the patch. I want to know exactly what went wrong instead
> of just saying "but the current interface unregister_ftrace_function()
> does not seem to guarantee this", let's actually fix the bug and not just paper over it!
Bah, I forgot to edit the claws-mail shortcut to disable "Ctrl-Enter"
to send the email, and went to hit Ctrl-L (to do the line wrapping) but
accidentally hit Ctrl-Enter instead, and sent this prematurely. And now
I forgot what else I was going to say. Sucks getting old.
-- Steve
prev parent reply other threads:[~2021-03-25 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 10:25 [PATCH 0/2] Fix the race on &event->ftrace_ops between perf and ftrace Li Huafei
2021-03-17 10:25 ` [PATCH 1/2] ftrace: Update ftrace_ops->next pointer with rcu_assign_pointer() Li Huafei
2021-03-25 1:20 ` Steven Rostedt
2021-03-17 10:25 ` [PATCH 2/2] perf, ftrace: Fix use-after-free in __ftrace_ops_list_func() Li Huafei
2021-03-25 1:11 ` Steven Rostedt
2021-03-25 1:14 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324211455.35beb1e2@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=jolsa@redhat.com \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=xukuohai@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=zhangjinhao2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®