mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Julian Braha <julianbraha@gmail.com>,
	Chuck Lever <chuck.lever@oracle.com>,
	Sasha Levin <sashal@kernel.org>,
	linux-nfs@vger.kernel.org
Subject: [PATCH AUTOSEL 5.4 03/24] fs: nfsd: fix kconfig dependency warning for NFSD_V4
Date: Thu, 25 Mar 2021 07:26:29 -0400	[thread overview]
Message-ID: <20210325112651.1927828-3-sashal@kernel.org> (raw)
In-Reply-To: <20210325112651.1927828-1-sashal@kernel.org>

From: Julian Braha <julianbraha@gmail.com>

[ Upstream commit 7005227369079963d25fb2d5d736d0feb2c44cf6 ]

When NFSD_V4 is enabled and CRYPTO is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for CRYPTO_SHA256
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - NFSD_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFSD [=y] && PROC_FS [=y]

WARNING: unmet direct dependencies detected for CRYPTO_MD5
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - NFSD_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFSD [=y] && PROC_FS [=y]

This is because NFSD_V4 selects CRYPTO_MD5 and CRYPTO_SHA256,
without depending on or selecting CRYPTO, despite those config options
being subordinate to CRYPTO.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/nfsd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
index f2f81561ebb6..4d6e71335bce 100644
--- a/fs/nfsd/Kconfig
+++ b/fs/nfsd/Kconfig
@@ -73,6 +73,7 @@ config NFSD_V4
 	select NFSD_V3
 	select FS_POSIX_ACL
 	select SUNRPC_GSS
+	select CRYPTO
 	select CRYPTO_MD5
 	select CRYPTO_SHA256
 	select GRACE_PERIOD
-- 
2.30.1


  parent reply	other threads:[~2021-03-25 11:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25 11:26 [PATCH AUTOSEL 5.4 01/24] ext4: shrink race window in ext4_should_retry_alloc() Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 02/24] ext4: fix bh ref count on error paths Sasha Levin
2021-03-25 11:26 ` Sasha Levin [this message]
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 04/24] rpc: fix NULL dereference on kmalloc failure Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 05/24] iomap: Fix negative assignment to unsigned sis->pages in iomap_swapfile_activate Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 06/24] ASoC: rt5640: Fix dac- and adc- vol-tlv values being off by a factor of 10 Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 07/24] ASoC: rt5651: " Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 08/24] ASoC: sgtl5000: set DAP_AVC_CTRL register to correct default value on probe Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 09/24] ASoC: es8316: Simplify adc_pga_gain_tlv table Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 10/24] ASoC: cs42l42: Fix Bitclock polarity inversion Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 11/24] ASoC: cs42l42: Fix channel width support Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 12/24] ASoC: cs42l42: Fix mixer volume control Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 13/24] ASoC: cs42l42: Always wait at least 3ms after reset Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 14/24] NFSD: fix error handling in NFSv4.0 callbacks Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 15/24] powerpc: Force inlining of cpu_has_feature() to avoid build failure Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 16/24] vhost: Fix vhost_vq_reset() Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 17/24] scsi: st: Fix a use after free in st_open() Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 18/24] scsi: qla2xxx: Fix broken #endif placement Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 19/24] staging: comedi: cb_pcidas: fix request_irq() warn Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 20/24] staging: comedi: cb_pcidas64: " Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 21/24] ASoC: rt5659: Update MCLK rate in set_sysclk() Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 22/24] thermal/core: Add NULL pointer check before using cooling device stats Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 23/24] locking/ww_mutex: Simplify use_ww_ctx & ww_ctx handling Sasha Levin
2021-03-25 11:26 ` [PATCH AUTOSEL 5.4 24/24] ext4: do not iput inode under running transaction in ext4_rename() Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210325112651.1927828-3-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=julianbraha@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®