From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2DAC433E1 for ; Fri, 26 Mar 2021 09:15:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91DB261A32 for ; Fri, 26 Mar 2021 09:15:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230197AbhCZJPi (ORCPT ); Fri, 26 Mar 2021 05:15:38 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:35276 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbhCZJPP (ORCPT ); Fri, 26 Mar 2021 05:15:15 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lPiYT-00034K-Bz; Fri, 26 Mar 2021 20:14:58 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 26 Mar 2021 20:14:57 +1100 Date: Fri, 26 Mar 2021 20:14:57 +1100 From: Herbert Xu To: Yang Shen Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, wangzhou1@hisilicon.com Subject: Re: [PATCH 4/4] crypto: hisilicon/zip - support new 'sqe' type in Kunpeng930 Message-ID: <20210326091457.GA1153@gondor.apana.org.au> References: <1616139187-63425-1-git-send-email-shenyang39@huawei.com> <1616139187-63425-5-git-send-email-shenyang39@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1616139187-63425-5-git-send-email-shenyang39@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 19, 2021 at 03:33:07PM +0800, Yang Shen wrote: > > +const struct hisi_zip_sqe_ops hisi_zip_ops_v2 = { > + .sqe_type = 0x3, > + .fill_addr = hisi_zip_fill_addr, > + .fill_buf_size = hisi_zip_fill_buf_size, > + .fill_buf_type = hisi_zip_fill_buf_type, > + .fill_req_type = hisi_zip_fill_req_type, > + .fill_tag = hisi_zip_fill_tag_v2, > + .fill_sqe_type = hisi_zip_fill_sqe_type, > + .get_tag = hisi_zip_get_tag_v2, > + .get_status = hisi_zip_get_status, > + .get_dstlen = hisi_zip_get_dstlen, > +}; > + This triggers a new warning: CHECK ../drivers/crypto/hisilicon/zip/zip_crypto.c ../drivers/crypto/hisilicon/zip/zip_crypto.c:527:31: warning: symbol 'hisi_zip_ops_v1' was not declared. Should it be static? ../drivers/crypto/hisilicon/zip/zip_crypto.c:540:31: warning: symbol 'hisi_zip_ops_v2' was not declared. Should it be static? Please fix. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt