From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45042C433DB for ; Sun, 28 Mar 2021 17:22:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BB606197F for ; Sun, 28 Mar 2021 17:22:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231408AbhC1RWC (ORCPT ); Sun, 28 Mar 2021 13:22:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:58486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbhC1RVx (ORCPT ); Sun, 28 Mar 2021 13:21:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 29DA16197E; Sun, 28 Mar 2021 17:21:51 +0000 (UTC) Date: Sun, 28 Mar 2021 18:21:48 +0100 From: Catalin Marinas To: Chen Lifu Cc: will@kernel.org, valentin.schneider@arm.com, maz@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, heying24@huawei.com, yuehaibing@huawei.com, weiyongjun1@huawei.com, johnny.chenyi@huawei.com Subject: Re: [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions Message-ID: <20210328172147.GA19252@arm.com> References: <20210327070651.70773-1-chenlifu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210327070651.70773-1-chenlifu@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 27, 2021 at 03:06:51PM +0800, Chen Lifu wrote: > In commit eb631bb5bf5b > ("arm64: Support arch_irq_work_raise() via self IPIs") a new > function "arch_irq_work_raise" was added without a prototype > in header irq_work.h > > In commit d914d4d49745 > ("arm64: Implement panic_smp_self_stop()") a new > function "panic_smp_self_stop" was added without a prototype > in header irq_work.h > > We get the following warnings on W=1: > arch/arm64/kernel/smp.c:842:6: warning: no previous prototype > for ‘arch_irq_work_raise’ [-Wmissing-prototypes] > arch/arm64/kernel/smp.c:862:6: warning: no previous prototype > for ‘panic_smp_self_stop’ [-Wmissing-prototypes] > > Fix the same by adding the missing prototype in header irq_work.h > > Signed-off-by: Chen Lifu > --- > arch/arm64/include/asm/irq_work.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h > index a1020285ea75..f766e2190e7c 100644 > --- a/arch/arm64/include/asm/irq_work.h > +++ b/arch/arm64/include/asm/irq_work.h > @@ -2,6 +2,9 @@ > #ifndef __ASM_IRQ_WORK_H > #define __ASM_IRQ_WORK_H > > +extern void arch_irq_work_raise(void); > +extern void panic_smp_self_stop(void); The second prototype makes more sense in arch/arm64/include/asm/smp.h where we already have crash_smp_send_stop(). -- Catalin