From: Chen Lifu <chenlifu@huawei.com>
To: <catalin.marinas@arm.com>, <will@kernel.org>,
<valentin.schneider@arm.com>, <maz@kernel.org>,
<dbrazdil@google.com>, <mark.rutland@arm.com>,
<wangkefeng.wang@huawei.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <heying24@huawei.com>, <yuehaibing@huawei.com>,
<weiyongjun1@huawei.com>, <johnny.chenyi@huawei.com>,
Chen Lifu <chenlifu@huawei.com>
Subject: [PATCH v2 -next] arm64: smp: Add missing prototype for some smp.c functions
Date: Mon, 29 Mar 2021 11:43:43 +0800 [thread overview]
Message-ID: <20210329034343.183974-1-chenlifu@huawei.com> (raw)
In-Reply-To: <20210328172147.GA19252@arm.com>
In commit eb631bb5bf5b
("arm64: Support arch_irq_work_raise() via self IPIs") a new
function "arch_irq_work_raise" was added without a prototype.
In commit d914d4d49745
("arm64: Implement panic_smp_self_stop()") a new
function "panic_smp_self_stop" was added without a prototype.
We get the following warnings on W=1:
arch/arm64/kernel/smp.c:842:6: warning: no previous prototype
for ‘arch_irq_work_raise’ [-Wmissing-prototypes]
arch/arm64/kernel/smp.c:862:6: warning: no previous prototype
for ‘panic_smp_self_stop’ [-Wmissing-prototypes]
Fix the warnings by:
1. Adding the prototype for 'arch_irq_work_raise' in irq_work.h
2. Adding the prototype for 'panic_smp_self_stop' in smp.h
Signed-off-by: Chen Lifu <chenlifu@huawei.com>
---
v2:
- move the prototype for 'panic_smp_self_stop' to smp.h
arch/arm64/include/asm/irq_work.h | 2 ++
arch/arm64/include/asm/smp.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h
index a1020285ea75..81bbfa3a035b 100644
--- a/arch/arm64/include/asm/irq_work.h
+++ b/arch/arm64/include/asm/irq_work.h
@@ -2,6 +2,8 @@
#ifndef __ASM_IRQ_WORK_H
#define __ASM_IRQ_WORK_H
+extern void arch_irq_work_raise(void);
+
static inline bool arch_irq_work_has_interrupt(void)
{
return true;
diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
index bcb01ca15325..0e357757c0cc 100644
--- a/arch/arm64/include/asm/smp.h
+++ b/arch/arm64/include/asm/smp.h
@@ -145,6 +145,7 @@ bool cpus_are_stuck_in_kernel(void);
extern void crash_smp_send_stop(void);
extern bool smp_crash_stop_failed(void);
+extern void panic_smp_self_stop(void);
#endif /* ifndef __ASSEMBLY__ */
--
2.17.1
next prev parent reply other threads:[~2021-03-29 3:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 7:06 [PATCH " Chen Lifu
2021-03-28 17:21 ` Catalin Marinas
2021-03-29 3:43 ` Chen Lifu [this message]
2021-03-29 12:28 ` [PATCH v2 " Catalin Marinas
2021-03-30 1:37 ` chenlifu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329034343.183974-1-chenlifu@huawei.com \
--to=chenlifu@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=dbrazdil@google.com \
--cc=heying24@huawei.com \
--cc=johnny.chenyi@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=valentin.schneider@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=will@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®