From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: [tip:irq/core 2/2] kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR'
Date: Tue, 30 Mar 2021 12:58:59 +0300 [thread overview]
Message-ID: <20210330095859.GB2065@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 1985 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
head: e6d46eded43dacf6370a7ae70f927ef4692cfcab
commit: e6d46eded43dacf6370a7ae70f927ef4692cfcab [2/2] genirq/irq_sim: Shrink devm_irq_domain_create_sim()
config: x86_64-randconfig-m001-20210328 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR'
vim +/ERR_PTR +246 kernel/irq/irq_sim.c
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14 233 struct irq_domain *devm_irq_domain_create_sim(struct device *dev,
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14 234 struct fwnode_handle *fwnode,
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14 235 unsigned int num_irqs)
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14 236 {
e6d46eded43dac Bartosz Golaszewski 2021-03-01 237 struct irq_domain *domain;
e6d46eded43dac Bartosz Golaszewski 2021-03-01 238 int ret;
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14 239
e6d46eded43dac Bartosz Golaszewski 2021-03-01 240 domain = irq_domain_create_sim(fwnode, num_irqs);
e6d46eded43dac Bartosz Golaszewski 2021-03-01 241 if (IS_ERR(domain))
e6d46eded43dac Bartosz Golaszewski 2021-03-01 242 return domain;
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14 243
e6d46eded43dac Bartosz Golaszewski 2021-03-01 244 ret = devm_add_action_or_reset(dev, devm_irq_domain_remove_sim, domain);
e6d46eded43dac Bartosz Golaszewski 2021-03-01 245 if (!ret)
^^^
This is probably reversed. It should be "if (ret)"
e6d46eded43dac Bartosz Golaszewski 2021-03-01 @246 return ERR_PTR(ret);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32539 bytes --]
reply other threads:[~2021-03-30 10:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330095859.GB2065@kadam \
--to=dan.carpenter@oracle.com \
--cc=bgolaszewski@baylibre.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®