From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE08C433DB for ; Tue, 30 Mar 2021 14:25:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE429619BD for ; Tue, 30 Mar 2021 14:25:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231950AbhC3OZR (ORCPT ); Tue, 30 Mar 2021 10:25:17 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:54790 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S231882AbhC3OYt (ORCPT ); Tue, 30 Mar 2021 10:24:49 -0400 X-UUID: 36093d43e0884872946b8d49f557ef4a-20210330 X-UUID: 36093d43e0884872946b8d49f557ef4a-20210330 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 275825953; Tue, 30 Mar 2021 22:24:47 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 30 Mar 2021 22:24:39 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 30 Mar 2021 22:24:40 +0800 From: Lecopzer Chen To: CC: , , , , , , , Subject: Re: [PATCH] irqchip/gic-v3: Fix IPRIORITYR can't perform byte operations in GIC-600 Date: Tue, 30 Mar 2021 22:24:40 +0800 Message-ID: <20210330142440.30119-1-lecopzer.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <87eefwrash.wl-maz@kernel.org> References: <87eefwrash.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [...] > > > > > > > > From the architecture spec: > > > > > > > > > > > > 11.1.3 GIC memory-mapped register access > > > > > > > > In any system, access to the following registers must be supported: > > > > > > > > [...] > > > > * Byte accesses to: > > > > - GICD_IPRIORITYR. > > > > - GICD_ITARGETSR. > > > > - GICD_SPENDSGIR. > > > > - GICD_CPENDSGIR. > > > > - GICR_IPRIORITYR. > > > > > > > > > > > > So if GIC600 doesn't follow this architectural requirement, this is a > > > > HW erratum, and I want an actual description of the HW issue together > > > > with an erratum number. > > > > > > > > Lorenzo, can you please investigate on your side? > > > > > > Sure - I will look into it and report back. > > > > Checked - I don't think this patch is needed so it should be dropped and > > a follow-up discussion can continue in the relevant/appropriate forum - > > if there is anything left to discuss. > > Thanks for having had a look. This really smells like an integration > issue rather than an actual GIC bug. > > Lecopzer, please check with your HW people and potentially ARM, as I > think you are looking at the wrong problem. Thanks a lot for the suggestion and checking, I think I'll back to disscuss with ARM and our HW team to figure out the previous answer from ARM Support in detail. Thanks again! Lecopzer