From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626C2C433E5 for ; Tue, 30 Mar 2021 17:50:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 489F5619F5 for ; Tue, 30 Mar 2021 17:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232602AbhC3RuI (ORCPT ); Tue, 30 Mar 2021 13:50:08 -0400 Received: from verein.lst.de ([213.95.11.211]:60001 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232579AbhC3Rtp (ORCPT ); Tue, 30 Mar 2021 13:49:45 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C6B2468B05; Tue, 30 Mar 2021 19:49:43 +0200 (CEST) Date: Tue, 30 Mar 2021 19:49:43 +0200 From: Christoph Hellwig To: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de Subject: Re: [PATCH 2/3] MIPS: uaccess: Remove get_fs/set_fs call sites Message-ID: <20210330174943.GB15145@lst.de> References: <20210330172702.146909-1-tsbogend@alpha.franken.de> <20210330172702.146909-3-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330172702.146909-3-tsbogend@alpha.franken.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 30, 2021 at 07:26:59PM +0200, Thomas Bogendoerfer wrote: > +#define __get_data(x, ptr, u) \ > + (((u) == true) ? __get_udata((x), (ptr), sizeof(*(ptr))) : \ > + __get_kdata((x), (ptr), sizeof(*(ptr)))) > + I'm a little worried about exposing this in uaccess.h. Can you have local helpers insted, preferably strongly typed for their specific use cases?