From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3030C433C1 for ; Wed, 31 Mar 2021 05:39:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DAFF61957 for ; Wed, 31 Mar 2021 05:39:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233674AbhCaFjU (ORCPT ); Wed, 31 Mar 2021 01:39:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233469AbhCaFip (ORCPT ); Wed, 31 Mar 2021 01:38:45 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39FFEC061574 for ; Tue, 30 Mar 2021 22:38:45 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id kr3-20020a17090b4903b02900c096fc01deso633304pjb.4 for ; Tue, 30 Mar 2021 22:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=so4kPdZGFoamwj7jn02pOeYfcmVYyIUHQWGAZcaFn10=; b=rKPGhEE+Rpb55Y+wH2VI9M+g+CbYN7b60pMNpeMFERkGCaNWcFA5ovMGou3OJDRxa6 LgqxsTyj2qv/dunPClh5nXWoCkehko3yq0F/aSwMlkv2no5Muyj37a2/f7l6h9b3UlH+ ZQa94I4F5M+b3bULumUVrq3F8Usp/ksSXSgefIusgh8uUC7FlofQjEaqw0Avus7+oEIn BYWaRbuqGzHlUqN+jlTcn0MP7V7FWVhcEhIePkBizpNj+3ib0yCielUX7wRmOosW+JRC G86LJytujySISpCUvjWMFR6MMknX6roLyYqN2FgBsTejTlP1RhMSPsqDNyIa55naUyZH bGhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=so4kPdZGFoamwj7jn02pOeYfcmVYyIUHQWGAZcaFn10=; b=Y9XVFAECDJ6SgZ1PqGNwCwQSwVJZQkaShqW4sxmbOB/ABrU8DEkMkZcpAaU62qtS/b tv4Fr75KyTWavQYbx6hK8EcRVpWLZjzOQ9wzwirSknnPRWEHpfU73r4MLOk0ADRb40+L F5hI/q8WFNAR9KPgZggImgb6NISlgdnSz7xllrvDroqECN+O2ManfLQNcjFG4aGMYjCK fuU9oSob6swkaWh/BME86qFcZ6pZj8w81pEaqKW7j1yyuqSAj2zc4Nh47sBz8G/zULVZ ULuLle1774v95oOGBz86KlHXcuRhgKS0ARqDh77egBha+tmE7SJPU1V1aDKU3Y9DEKRc EOqQ== X-Gm-Message-State: AOAM530t+s8Ufv43z9rZkbwG4H+2z5l5lSMKNzj9YHbwhvLPZB2CX1fT +QWsBzJ1k4URnf48E7cBbZg= X-Google-Smtp-Source: ABdhPJzILXsBBcm9/2UVHKX/l2IG/3Q47xJzcSv/8uLdFteP0ORGJisw+JPl2XRzyz17nShPOWgamA== X-Received: by 2002:a17:902:7585:b029:e6:cc10:61fe with SMTP id j5-20020a1709027585b02900e6cc1061femr1608189pll.23.1617169124752; Tue, 30 Mar 2021 22:38:44 -0700 (PDT) Received: from djbComp (S0106ac202ecb0523.gv.shawcable.net. [70.67.120.89]) by smtp.gmail.com with ESMTPSA id k27sm714813pfg.95.2021.03.30.22.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Mar 2021 22:38:44 -0700 (PDT) Date: Tue, 30 Mar 2021 22:38:43 -0700 From: Deborah Brouwer To: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, marcocesati@gmail.com, fabioaiuto83@gmail.com, dan.carpenter@oracle.com, phil@philpotter.co.uk, amarjargal16@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH] staging: rtl8723bs: fix block comments Message-ID: <20210331053841.GA6091@djbComp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove empty comment and fix checkpatch warnings: WARNING: Block comments use * on subsequent lines WARNING: Possible repeated word: 'very' Signed-off-by: Deborah Brouwer --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 61 +++++++++++------------ 1 file changed, 28 insertions(+), 33 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 2daf5c461a4d..7b4c0f22cd90 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -46,8 +46,8 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) init_completion(&pxmitpriv->terminate_xmitthread_comp); /* - Please insert all the queue initializaiton using _rtw_init_queue below - */ + * Please insert all the queue initializaiton using _rtw_init_queue below + */ pxmitpriv->adapter = padapter; @@ -60,10 +60,10 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) _rtw_init_queue(&pxmitpriv->free_xmit_queue); /* - Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, - and initialize free_xmit_frame below. - Please also apply free_txobj to link_up all the xmit_frames... - */ + * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, + * and initialize free_xmit_frame below. + * Please also apply free_txobj to link_up all the xmit_frames... + */ pxmitpriv->pallocated_frame_buf = vzalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4); @@ -876,8 +876,6 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfr *(payload+curfragnum), *(payload+curfragnum+1), *(payload+curfragnum+2), *(payload+curfragnum+3), *(payload+curfragnum+4), *(payload+curfragnum+5), *(payload+curfragnum+6), *(payload+curfragnum+7))); } -/* -*/ } return _SUCCESS; } @@ -1069,17 +1067,15 @@ u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *pattrib) } /* - -This sub-routine will perform all the following: - -1. remove 802.3 header. -2. create wlan_header, based on the info in pxmitframe -3. append sta's iv/ext-iv -4. append LLC -5. move frag chunk from pframe to pxmitframe->mem -6. apply sw-encrypt, if necessary. - -*/ + * This sub-routine will perform all the following: + * + * 1. remove 802.3 header. + * 2. create wlan_header, based on the info in pxmitframe + * 3. append sta's iv/ext-iv + * 4. append LLC + * 5. move frag chunk from pframe to pxmitframe->mem + * 6. apply sw-encrypt, if necessary. + */ s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe) { struct pkt_file pktfile; @@ -1693,23 +1689,22 @@ static void rtw_init_xmitframe(struct xmit_frame *pxframe) } /* -Calling context: -1. OS_TXENTRY -2. RXENTRY (rx_thread or RX_ISR/RX_CallBack) - -If we turn on USE_RXTHREAD, then, no need for critical section. -Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... - -Must be very very cautious... - -*/ + * Calling context: + * 1. OS_TXENTRY + * 2. RXENTRY (rx_thread or RX_ISR/RX_CallBack) + * + * If we turn on USE_RXTHREAD, then, no need for critical section. + * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... + * + * Must be very, very cautious... + */ struct xmit_frame *rtw_alloc_xmitframe(struct xmit_priv *pxmitpriv)/* _queue *pfree_xmit_queue) */ { /* - Please remember to use all the osdep_service api, - and lock/unlock or _enter/_exit critical to protect - pfree_xmit_queue - */ + * Please remember to use all the osdep_service api, + * and lock/unlock or _enter/_exit critical to protect + * pfree_xmit_queue + */ struct xmit_frame *pxframe = NULL; struct list_head *plist, *phead; -- 2.17.1