From: Mark Brown <broonie@kernel.org>
To: Steve Lee <steves.lee@maximintegrated.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
ckeepax@opensource.cirrus.com, geert@linux-m68k.org,
rf@opensource.wolfsonmicro.com, shumingf@realtek.com,
srinivas.kandagatla@linaro.org, krzk@kernel.org, dmurphy@ti.com,
jack.yu@realtek.com, nuno.sa@analog.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
ryan.lee.maxim@gmail.com, steves.lee.maxim@gmail.com
Subject: Re: [PATCH] ASoC: max98390: Add controls for tx path
Date: Fri, 2 Apr 2021 16:23:26 +0100 [thread overview]
Message-ID: <20210402152326.GA5402@sirena.org.uk> (raw)
In-Reply-To: <20210402033643.12259-1-steves.lee@maximintegrated.com>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Fri, Apr 02, 2021 at 12:36:43PM +0900, Steve Lee wrote:
> + SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A,
> + 0, 255, 0),
I'm not clear what this is (especially given the source selection below)
but it looks like it should be a mute control?
> + SOC_SINGLE("Tx Hiz Selection", MAX98390_PCM_TX_HIZ_CTRL_A,
> + 0, 255, 0),
This I'd expect to be tied into machine driver configuration, either DT
properties or TDM slot configuration - it's not something that looks
like it's something you'd want to control at runtime.
> + SOC_SINGLE("Tx Source Selection", MAX98390_PCM_CH_SRC_2,
> + 0, 255, 0),
This looks like it should be a DAPM control or possibly a TDM slot
configuration - look at how the Arizona devices handle routing from
multiple TDM slots for the DAPM version.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-02 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 3:36 Steve Lee
2021-04-02 15:23 ` Mark Brown [this message]
2021-04-03 1:33 ` [EXTERNAL] " Steve Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402152326.GA5402@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=dmurphy@ti.com \
--cc=geert@linux-m68k.org \
--cc=jack.yu@realtek.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=perex@perex.cz \
--cc=rf@opensource.wolfsonmicro.com \
--cc=ryan.lee.maxim@gmail.com \
--cc=shumingf@realtek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=steves.lee.maxim@gmail.com \
--cc=steves.lee@maximintegrated.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®