mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] doc: Fix mistaken diagram references in RCU
Date: Sun, 4 Apr 2021 17:29:35 -0700	[thread overview]
Message-ID: <20210405002935.GD2696@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20210404215843.8413-1-frederic@kernel.org>

On Sun, Apr 04, 2021 at 11:58:43PM +0200, Frederic Weisbecker wrote:
> The 3 diagrams describing rcu_gp_init() all spuriously refer to the same
> figure, probably due to some copy/paste issue. Fix the references.
> 
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>

Good catch, queued, thank you!

							Thanx, Paul

> ---
>  .../RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst   | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst b/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
> index 3f6ce41ee0c5..11cdab037bff 100644
> --- a/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
> +++ b/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
> @@ -339,14 +339,14 @@ The diagram below shows the path of ordering if the leftmost
>  leftmost ``rcu_node`` structure offlines its last CPU and if the next
>  ``rcu_node`` structure has no online CPUs).
>  
> -.. kernel-figure:: TreeRCU-gp-init-1.svg
> +.. kernel-figure:: TreeRCU-gp-init-2.svg
>  
>  The final ``rcu_gp_init()`` pass through the ``rcu_node`` tree traverses
>  breadth-first, setting each ``rcu_node`` structure's ``->gp_seq`` field
>  to the newly advanced value from the ``rcu_state`` structure, as shown
>  in the following diagram.
>  
> -.. kernel-figure:: TreeRCU-gp-init-1.svg
> +.. kernel-figure:: TreeRCU-gp-init-3.svg
>  
>  This change will also cause each CPU's next call to
>  ``__note_gp_changes()`` to notice that a new grace period has started,
> -- 
> 2.25.1
> 

      reply	other threads:[~2021-04-05  0:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-04 21:58 Frederic Weisbecker
2021-04-05  0:29 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210405002935.GD2696@paulmck-ThinkPad-P72 \
    --to=paulmck@kernel.org \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®