From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BDA8C433ED for ; Mon, 5 Apr 2021 22:25:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52DC7613D6 for ; Mon, 5 Apr 2021 22:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242773AbhDEWZf (ORCPT ); Mon, 5 Apr 2021 18:25:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:43648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233086AbhDEWZ3 (ORCPT ); Mon, 5 Apr 2021 18:25:29 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96472613D6; Mon, 5 Apr 2021 22:25:22 +0000 (UTC) Date: Mon, 5 Apr 2021 18:25:21 -0400 From: Steven Rostedt To: "Yordan Karadzhov (VMware)" Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org Subject: Re: [PATCH v2 5/5] tracing: Add "func_no_repeats" option for function tracing Message-ID: <20210405182521.07f0d1ab@gandalf.local.home> In-Reply-To: <20210329130533.199507-6-y.karadz@gmail.com> References: <20210329130533.199507-1-y.karadz@gmail.com> <20210329130533.199507-6-y.karadz@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Mar 2021 16:05:33 +0300 "Yordan Karadzhov (VMware)" wrote: > If the option is activated the function tracing record gets > consolidated in the cases when a single function is called number > of times consecutively. Instead of having an identical record for > each call of the function we will record only the first call > following by event showing the number of repeats. > > Signed-off-by: Yordan Karadzhov (VMware) > > fix last You seem to have left the above extra text "fix last" in both versions. But the rest of the patch looks fine. -- Steve