From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63310C433B4 for ; Tue, 6 Apr 2021 02:36:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 389EA610A8 for ; Tue, 6 Apr 2021 02:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243406AbhDFCgS (ORCPT ); Mon, 5 Apr 2021 22:36:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232271AbhDFCgL (ORCPT ); Mon, 5 Apr 2021 22:36:11 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E491BC06174A; Mon, 5 Apr 2021 19:36:04 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id z15so13567634oic.8; Mon, 05 Apr 2021 19:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hRox+m0HCb4FpA/EUkWFuOtMM3ToOUYtmjxD+DRH/Zk=; b=tgksicBzGTwv+4lr27tWfD7Sz8d41BnclMCik4S3ZhaI4KcPE91jCI+gpFgRVZXK1w 3kbsaYp922RsZP/XWMbkoWoF3EKn6cLRWw3ykIeQFRvj0URm8n7EG+LTpLS8xB1xgw0U tuuLQwam8fXq20b6cgL64OmYukkypd94abBUowZZdifDsnck5a0MOGbM7kRn8+/AAuZh 3f9iNEU9xo3+TB5foE0/HUGMuhI1m4p7o37TnrN44XafVSESLuAGmpHTXURM0DIlBdgP qUZU7tcc0DEGLkUvbNmaL9lgLekN8z2c8khpQK7U2KReOM5m8NDkI0acSHfrOFsnf3sQ e9fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=hRox+m0HCb4FpA/EUkWFuOtMM3ToOUYtmjxD+DRH/Zk=; b=CcjWRqy8Xfa0wQrlFZMKZRQHZOgKglAX+bz44Td6H33aqww+XBvKS4HarcMi6lOS2I PG5WCQnFks0WLcrTxeT1sbA/FIMfp299AKH1uCDtQhRBGLFdpowKfr+VoqEMeqq7rbA8 nvL4j5Pn6bYojb6hR2go3Zyaf+qc0bYozgwQnzsMZDeN3uaz6Yk/eAAMO7SJkls+ROf7 oJi9fhoRJa3zXd4sQnB+ujcMs2nQZpU+qhOItYlZD0KtF7BOADjVr6zEWJgip25d/Uxb UYMy3IVld96HuV78cymvXcRcObhsQvNh3ZQML//sF9mqd9Exf/XtagTNayRJ2Zt5rjMt 6IDA== X-Gm-Message-State: AOAM533mIHCFH1SHosY0FYushLxCAmfM6vRCd+fCI9BiQZKf1FkOOS8n vg5GfJBqgkp7p8yZpe/bOVU= X-Google-Smtp-Source: ABdhPJxWjfNE5zWQbDfPlN0GspOurtHhrnrEWCHTBvaJzl2TET6lapIsZYDkdc8OSKiEP41d4AjbZQ== X-Received: by 2002:aca:1e11:: with SMTP id m17mr1484928oic.61.1617676564228; Mon, 05 Apr 2021 19:36:04 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id g21sm3847456ooa.15.2021.04.05.19.36.03 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Apr 2021 19:36:03 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 5 Apr 2021 19:36:02 -0700 From: Guenter Roeck To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, stable@vger.kernel.org Subject: Re: [PATCH 4.9 00/35] 4.9.265-rc1 review Message-ID: <20210406023602.GB20578@roeck-us.net> References: <20210405085018.871387942@linuxfoundation.org> <20210405175629.GB93485@roeck-us.net> <20210405235155.GA75187@roeck-us.net> <20210406022200.GA20578@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406022200.GA20578@roeck-us.net> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 05, 2021 at 07:22:00PM -0700, Guenter Roeck wrote: > On Mon, Apr 05, 2021 at 04:51:55PM -0700, Guenter Roeck wrote: > > On Mon, Apr 05, 2021 at 10:56:29AM -0700, Guenter Roeck wrote: > > > On Mon, Apr 05, 2021 at 10:53:35AM +0200, Greg Kroah-Hartman wrote: > > > > This is the start of the stable review cycle for the 4.9.265 release. > > > > There are 35 patches in this series, all will be posted as a response > > > > to this one. If anyone has any issues with these being applied, please > > > > let me know. > > > > > > > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +0000. > > > > Anything received after that time might be too late. > > > > > > > > > > Build results: > > > total: 163 pass: 163 fail: 0 > > > Qemu test results: > > > total: 383 pass: 382 fail: 1 > > > Failed tests: > > > parisc:generic-32bit_defconfig:smp:net,pcnet:scsi[53C895A]:rootfs > > > > > > In the failing test, the network interfcace instantiates but fails to get > > > an IP address. This is not a new problem but a new test. For some reason > > > it only happens with this specific network interface, this specific SCSI > > > controller, and with v4.9.y. No reason for concern; I'll try to track down > > > what is going on. > > > > > > > Interesting. The problem affects all kernels up to and including > > v4.19.y. Unlike I thought initially, the problem is not associated > > with the SCSI controller (that was coincidental) but with pcnet > > Ethernet interfaces. It has been fixed in the upstream kernel with > > commit 518a2f1925c3 ("dma-mapping: zero memory returned from > > dma_alloc_*"). This patch does not apply cleanly to any of the > > affected kernels. I backported part of it to v4.19.y and v4.9.y > > and confirmed that it fixes the problem in those branches. > > > > Question is what we should do: try to backport 518a2f1925c3 to v4.19.y > > and earlier, or stop testing against this specific problem. > > > > Another update: The following code change fixes the problem as well. > Commit 518a2f1925c3 fixes it only as side effect since it clears > all DMA buffers. > > diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c > index c22bf52d3320..7a25ec8390e4 100644 > --- a/drivers/net/ethernet/amd/pcnet32.c > +++ b/drivers/net/ethernet/amd/pcnet32.c > @@ -1967,7 +1967,7 @@ static int pcnet32_alloc_ring(struct net_device *dev, const char *name) > return -ENOMEM; > } > > - lp->rx_ring = pci_alloc_consistent(lp->pci_dev, > + lp->rx_ring = pci_zalloc_consistent(lp->pci_dev, > sizeof(struct pcnet32_rx_head) * > lp->rx_ring_size, > &lp->rx_ring_dma_addr); > > I'll submit a patch implementing that; we'll see how it goes. Sigh. That doesn't work; upstream uses dma_alloc_coherent(). We could apply the patch making the switch, but dma_alloc_coherent() doesn't clear memory in older kernels (we are back to commit 518a2f1925c3 which is introducing that). I'll just drop pcnet tests for kernels older than v5.4. Guenter