From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98EA8C433ED for ; Tue, 6 Apr 2021 12:27:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62B996139E for ; Tue, 6 Apr 2021 12:27:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242097AbhDFM1h (ORCPT ); Tue, 6 Apr 2021 08:27:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:43494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241745AbhDFM1g (ORCPT ); Tue, 6 Apr 2021 08:27:36 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 55BB76121E; Tue, 6 Apr 2021 12:27:28 +0000 (UTC) Date: Tue, 6 Apr 2021 08:27:26 -0400 From: Steven Rostedt To: Jiapeng Chong Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ftrace: Check if pages were allocated before calling free_pages() Message-ID: <20210406082726.3b25a2f6@gandalf.local.home> In-Reply-To: <1617691905-8016-1-git-send-email-jiapeng.chong@linux.alibaba.com> References: <1617691905-8016-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Apr 2021 14:51:45 +0800 Jiapeng Chong wrote: > It is possible that on error pg->size can be zero when getting its > order,which would return a -1 value. It is dangerous to pass in an > order of -1 to free_pages(). Check if order is greater than or equal > to zero before calling free_pages(). > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > kernel/trace/ftrace.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index b7e29db..74efc33 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -6811,7 +6811,8 @@ void ftrace_free_mem(struct module *mod, void *start_ptr, void *end_ptr) > if (!pg->index) { > *last_pg = pg->next; > order = get_count_order(pg->size / ENTRIES_PER_PAGE); > - free_pages((unsigned long)pg->records, order); > + if (order >= 0) > + free_pages((unsigned long)pg->records, order); This has already been fixed upstream. -- Steve > ftrace_number_of_pages -= 1 << order; > ftrace_number_of_groups--; > kfree(pg);