From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Rex-BC Chen <rex-bc.chen@mediatek.com>
Cc: thierry.reding@gmail.com, lee.jones@linaro.org,
matthias.bgg@gmail.com, linux-pwm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Jitao Shi <jitao.shi@mediatek.com>
Subject: Re: [v3,PATCH 1/3] pwm: mtk_disp: clear the clock operations
Date: Tue, 6 Apr 2021 12:07:56 +0200 [thread overview]
Message-ID: <20210406100756.ijthlp2j3a3eygdt@pengutronix.de> (raw)
In-Reply-To: <1617703062-4251-2-git-send-email-rex-bc.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
Hello,
On Tue, Apr 06, 2021 at 05:57:40PM +0800, Rex-BC Chen wrote:
> Remove the clk_prepare from mtk_disp_pwm_probe.
> Remove the clk_unprepare from mtk_disp_pwm_remove.
>
> After using atomic API and get_state() function which are implemented
> in PATCH [2/3], [3/3],
Refering to the following patches as 2/3 and 3/3 doesn't make sense once
these patches are applied to a tree.
> clk_prepare/clk_unprepare are useless in probe/remove function.
> So we remove clk_prepare/clk_unprepare in probe/remove fuinction.
Does the driver still work with only this patch applied? If not, please
rearrange and order this patch after the conversion to the atomic API.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-06 10:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 9:57 [v3,PATCH 0/3] Convert the mtk_disp driver to aotmic API Rex-BC Chen
2021-04-06 9:57 ` [v3,PATCH 1/3] pwm: mtk_disp: clear the clock operations Rex-BC Chen
2021-04-06 10:07 ` Uwe Kleine-König [this message]
2021-04-06 9:57 ` [v3,PATCH 2/3] pwm: mtk_disp: convert the driver to atomic API Rex-BC Chen
2021-04-06 10:19 ` Uwe Kleine-König
2021-04-06 14:37 ` kernel test robot
2021-04-06 14:52 ` kernel test robot
2021-04-06 9:57 ` [v3,PATCH 3/3] pwm: mtk_disp: implement .get_state() Rex-BC Chen
2021-04-06 10:27 ` Uwe Kleine-König
2021-04-09 12:24 ` Thierry Reding
2021-04-09 21:52 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406100756.ijthlp2j3a3eygdt@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=jitao.shi@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rex-bc.chen@mediatek.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®