From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAD4CC433ED for ; Wed, 7 Apr 2021 06:18:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76B026139E for ; Wed, 7 Apr 2021 06:18:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345549AbhDGGSP (ORCPT ); Wed, 7 Apr 2021 02:18:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239344AbhDGGSO (ORCPT ); Wed, 7 Apr 2021 02:18:14 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99487C06174A for ; Tue, 6 Apr 2021 23:18:05 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id 7so17605096qka.7 for ; Tue, 06 Apr 2021 23:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xIfUyYNnxYrEolMH/sMUfASa4wWn6Y+xP/kPL0t8+t8=; b=SurtwhsEkXWoCwNSVb3ddR2j3JJ7P3SY5msQzOw1nGih+ntgNnrS/fi8MiKno0gOLw 6lv1KVyV95JkNahl9RrhBHIvcSe7wQoBDUM19FXFKctmb51hXfyavJ2X+McgGOpK471L MDSA3bNXUONeujYSLH8dtHL47fKcCtswOSqhiJ8M7VmSYBWQl/NqFw4mv6dGPS+hZlA5 f1E336B7iEeikgxLNOrCg63Ptndqn6FMR+y5kCQRzQwF6l6IFaAmdOh4SSkNiJFVacjr qfk2pWDgibZd/KSjk1jBYO0xLcL3Rn5VVKAYMs+KLXKQQFWwypazDx9aWamJFrH3hazP 0VZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xIfUyYNnxYrEolMH/sMUfASa4wWn6Y+xP/kPL0t8+t8=; b=U8GJ3n3rvFPYfwn1/fqD4FRQ6v8w36J4ThIYQUsvrEjs0zgQ9QoXZd+HiJbd30zCnc +AAmQ1kF/1CzLXod21s3QjMNETyIApyPruXB49JdIO0V5M5/z+rzXz9X8pKiOc0McCMB gm3R3xgLy1HPfydoHQV/Vmh0unUzzFh5Yywc+kUD1qwUnc1PBoetsC3TUIS9Z08XP2ml 5BPz+hlws9HI/hzR6xwhHBQQstZtx826cdNemM7wwjixdcJYklnlSZiYhqNAgNCB6Vzk ELMz0PMxOkBwGCzcvbTz6TRUSH/uTp59KUXWv7YeoR+J1rqd35zkjNACpC2znffumFkM DJIw== X-Gm-Message-State: AOAM5321Xl/IYSXWBiFZ+Sv6zkvjSCxtz1WVbGx6EHwYA8hD1XbLagiv +nEc7Vl89DAaJyby3XYaCFI= X-Google-Smtp-Source: ABdhPJwFBPqZjnFHkJ2ofAOMmXA8OmnULvi8AcSJBtHEIjkij2FrEBkcRzVpSCaxKcRJhnjtO0Virw== X-Received: by 2002:a05:620a:110a:: with SMTP id o10mr1711378qkk.281.1617776284949; Tue, 06 Apr 2021 23:18:04 -0700 (PDT) Received: from ubuntu1.attlocal.net ([2600:1700:5435:9040:8fbe:64f5:9b30:a6f0]) by smtp.googlemail.com with ESMTPSA id z6sm15771716qtv.69.2021.04.06.23.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:18:04 -0700 (PDT) From: Vardhan H G To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Vardhan H G Subject: [PATCH] staging: rt8192u: change constants to be on right Date: Tue, 6 Apr 2021 23:17:49 -0700 Message-Id: <20210407061749.13460-1-crazylonestar7@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When comparing a constant with variable, it is recommeneded to have the constant on the right side of the test. This patch silences the following checkpatch.pl warning: "Comparisons should place the constant on the right side of the test" Signed-off-by: Vardhan H G --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c index 379a2ccf4d9f..6823e405eeb8 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c @@ -140,7 +140,7 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, s // Dialog Token *tag++ = pBA->dialog_token; - if (ACT_ADDBARSP == type) { + if (type == ACT_ADDBARSP) { // Status Code netdev_info(ieee->dev, "=====>to send ADDBARSP\n"); @@ -156,7 +156,7 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, s put_unaligned_le16(pBA->timeout_value, tag); tag += 2; - if (ACT_ADDBAREQ == type) { + if (type == ACT_ADDBAREQ) { // BA Start SeqCtrl memcpy(tag, (u8 *)&(pBA->start_seq_ctrl), 2); tag += 2; -- 2.27.0