From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65415C43461 for ; Wed, 7 Apr 2021 18:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1655661168 for ; Wed, 7 Apr 2021 18:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355441AbhDGSvC (ORCPT ); Wed, 7 Apr 2021 14:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348578AbhDGSvA (ORCPT ); Wed, 7 Apr 2021 14:51:00 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8201BC06175F for ; Wed, 7 Apr 2021 11:50:50 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id y13so24720925ybk.20 for ; Wed, 07 Apr 2021 11:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=Z+cU0cubea5IW7G2rrulWCH4/axSqIvQteecVrrdERs=; b=datFYg43GzeOSYAuHMH4cqmENNE1YOtm17ojn/kK6cIRea+OF2hpgmVjn/o0YHNJ5k Ewdy0SXBoIjyZic7xDF/r4V92e+lchqNyynmUlCFVLIkCDAeSIRWS75aMmQJadTjntUK KLg/QA4uWUHOdOU0UqYooSENsQfAi7s9dwIyTZCiCAOTwYYO7cw8gD9LHD+l3JskoWMD rQR9QcfITlveNjXK8hynavgw2wMFWb2Kv79R2ZTOiUdb1s0qQl9JithlJXzHsMvL4/HT q/DlQ5OOnyX2HxiFIpkmdItdRHlzRs/T/xSy1HEUDRVcIVk535XJNurcXX8RoH9jfGsb zhkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Z+cU0cubea5IW7G2rrulWCH4/axSqIvQteecVrrdERs=; b=dFcVTwBhlV83Xm+asP1maj1nqqRpU2sLAC3w9ukURB8HFSot/X77Ikdy90vGZaYtrt 1Q8X2X8N/slfaOaUZfWpRn1rCVJrvB4qXaIpgBcSdC8FuSgg6ziY3c5xYK8zFywDl5sR nTopAwyu0scJuVFDfZzHPVJzHmDufiAk60VbLxgwl5hZYlUmPUMAeZTWPVEDyrmFbTXB l6FTsyyNuAyQnJrvfvhvx7UgT5NCIN9Fss3u9V3T516AFZzNp5GOCY9LezE49yhbI7bv iyd2SP/294Uw3Dk73bbJHZ+OazUk8WpW4Y7EcgA+py5ILvfKOtgtR62rQotubatY3SNY +1XQ== X-Gm-Message-State: AOAM531QYNSXx0ig4HRWOMcpQ7k60Cg1kokT/CcaAYua/n+G5c5+b0wS CwMzpCho0p+H/EPKZESbOzCjSdYhWVU= X-Google-Smtp-Source: ABdhPJzEGo2Im1fwYKE3dyy1xIw1Znu1ydIrq8lcJTb+KNSnCGfz5TR15GLDVFpKnfKOo7fjBPs3VaJsHuk= X-Received: from legoland2.mtv.corp.google.com ([2620:15c:211:1:c151:20a4:9e4a:b11e]) (user=varmam job=sendgmr) by 2002:a25:3057:: with SMTP id w84mr6161945ybw.62.1617821449791; Wed, 07 Apr 2021 11:50:49 -0700 (PDT) Date: Wed, 7 Apr 2021 11:50:39 -0700 In-Reply-To: <20210407185039.621248-1-varmam@google.com> Message-Id: <20210407185039.621248-3-varmam@google.com> Mime-Version: 1.0 References: <20210407185039.621248-1-varmam@google.com> X-Mailer: git-send-email 2.31.0.208.g409f899ff0-goog Subject: [PATCH v1 2/2] i2c: use "dev-name" device tree property to override device name From: Manish Varma To: Wolfram Sang , Rob Herring Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Manish Varma Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the dev_name field of i2c_board_info is not set while instantiating an I2C device, they are named like -, unless they are instantiated through ACPI. These coded names are less desirable in some situations as they will vary across systems with different hardware configurations, and even also on the same system as the adapter_id may change with change in the order of i2c bus enumeration (i.e. due to device tree modifications). These device names are further used by other modules like "system wakeup events framework" to assign the name of wakeup_source. So overall this causes somewhat difficult to interpret device and wakeup source names, and hence presents difficulties debuging issues at multiple levels. This change addresses above mentioned problem by setting dev_name field based on value assigned to an optional "dev-name" property of device tree (if present). And as a result of this, i2c_dev_set_name() should now use the actual device name instead of made up one. Signed-off-by: Manish Varma --- drivers/i2c/i2c-core-of.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c index 3ed74aa4b44b..d7a85a9cc499 100644 --- a/drivers/i2c/i2c-core-of.c +++ b/drivers/i2c/i2c-core-of.c @@ -58,6 +58,8 @@ int of_i2c_get_board_info(struct device *dev, struct device_node *node, if (of_get_property(node, "wakeup-source", NULL)) info->flags |= I2C_CLIENT_WAKE; + of_property_read_string(node, "dev-name", &(info->dev_name)); + return 0; } EXPORT_SYMBOL_GPL(of_i2c_get_board_info); -- 2.31.1.295.g9ea45b61b8-goog