From: Oded Gabbay <ogabbay@kernel.org>
To: linux-kernel@vger.kernel.org
Subject: [PATCH 6/7] habanalabs: print on f/w boot unknown error
Date: Thu, 8 Apr 2021 18:22:33 +0300 [thread overview]
Message-ID: <20210408152234.15383-6-ogabbay@kernel.org> (raw)
In-Reply-To: <20210408152234.15383-1-ogabbay@kernel.org>
We need to print a message to the kernel log in case we encounter
an unknown error in the f/w boot to help the user understand what
happened.
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
---
drivers/misc/habanalabs/common/firmware_if.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/habanalabs/common/firmware_if.c b/drivers/misc/habanalabs/common/firmware_if.c
index 652571d3b8e6..4c096b6132b5 100644
--- a/drivers/misc/habanalabs/common/firmware_if.c
+++ b/drivers/misc/habanalabs/common/firmware_if.c
@@ -351,8 +351,12 @@ static int fw_read_errors(struct hl_device *hdev, u32 boot_err0_reg,
dev_dbg(hdev->dev, "Device security status %#x\n",
security_val);
- if (err_val & ~CPU_BOOT_ERR0_ENABLED)
+ if (err_val & ~CPU_BOOT_ERR0_ENABLED) {
+ dev_err(hdev->dev,
+ "Device boot error - unknown error 0x%08x\n",
+ err_val);
return -EIO;
+ }
return 0;
}
--
2.25.1
next prev parent reply other threads:[~2021-04-08 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 15:22 [PATCH 1/7] habanalabs/gaudi: clear QM errors only if not in stop_on_err mode Oded Gabbay
2021-04-08 15:22 ` [PATCH 2/7] habanalabs: send dynamic msi-x indexes to f/w Oded Gabbay
2021-04-08 15:22 ` [PATCH 3/7] habanalabs: move dram scrub to free sequence Oded Gabbay
2021-04-08 15:22 ` [PATCH 4/7] habanalabs/gaudi: derive security status from pci id Oded Gabbay
2021-04-08 15:22 ` [PATCH 5/7] habanalabs/gaudi: skip iATU if F/W security is enabled Oded Gabbay
2021-04-08 15:22 ` Oded Gabbay [this message]
2021-04-08 15:22 ` [PATCH 7/7] habanalabs: update to latest F/W communication header Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408152234.15383-6-ogabbay@kernel.org \
--to=ogabbay@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®