From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13DCEC43603 for ; Fri, 9 Apr 2021 06:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F238E61105 for ; Fri, 9 Apr 2021 06:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233488AbhDIGwU (ORCPT ); Fri, 9 Apr 2021 02:52:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:39368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233333AbhDIGwS (ORCPT ); Fri, 9 Apr 2021 02:52:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 06AAB610FC; Fri, 9 Apr 2021 06:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1617951093; bh=rpxdJ+VoQo4exBN4jPf+RLIrO1vUqpKfUs6VC0gjRv8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d8hSSOgx1UTougP+ANtHxesbQOAwBtspUUXVyNAHSGCgx361cOHfHF+Hp6l5GSk5K 8vPc5JDAneVT29XdrYpmGwCyZza4pdb+eKcrizHfBMK1Uv1Rp7nuNwFgizsyXhlA6T ydo/fTOE0h3ctovMUNK8ifP/uK6K+fA7ua07T604= Date: Thu, 8 Apr 2021 23:51:32 -0700 From: Andrew Morton To: Greg Kroah-Hartman Cc: Gioh Kim , linux-kernel@vger.kernel.org, ndesaulniers@google.com, dan.j.williams@intel.com, laniel_francis@privacyrequired.com, keescook@chromium.org, dja@axtens.net, haris.iqbal@ionos.com, jinpu.wang@ionos.com Subject: Re: [PATCH v4] lib/string: Introduce sysfs_streqcase Message-Id: <20210408235132.e62ace3277fd46f123f5ff1b@linux-foundation.org> In-Reply-To: References: <20210408130605.541796-1-gi-oh.kim@ionos.com> <20210408220502.8126bc2f278b5199707ec122@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Apr 2021 08:44:39 +0200 Greg Kroah-Hartman wrote: > On Thu, Apr 08, 2021 at 10:05:02PM -0700, Andrew Morton wrote: > > On Thu, 8 Apr 2021 15:06:05 +0200 Gioh Kim wrote: > > > > > As the name shows, it checks if strings are equal in case insensitive > > > manner. > > > > Peh. Who would die if we simply made sysfs_streq() case-insensitive? > > I doubt anyone, let's do that instead. There's a risk that people will write scripts/config/etc on a 5.13+ kernel and then find that they malfunction on earlier kernels...