From: Herbert Xu <herbert@gondor.apana.org.au>
To: Hui Tang <tanghui20@huawei.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
xuzaibo@huawei.com, wangzhou1@hisilicon.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] crypto: hisilicon/hpre - delete redundant log
Date: Fri, 9 Apr 2021 17:33:34 +1000 [thread overview]
Message-ID: <20210409073334.GC23134@gondor.apana.org.au> (raw)
In-Reply-To: <1617362669-40372-1-git-send-email-tanghui20@huawei.com>
On Fri, Apr 02, 2021 at 07:24:29PM +0800, Hui Tang wrote:
> 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
> necessary to do it here, so remove it.
>
> Signed-off-by: Hui Tang <tanghui20@huawei.com>
>
> v1 -> v2:
> - Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero.
> ---
> drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Your patch description is misleading as the patch does moe than
just remove the redundant printk. Please rephrase so that it is
clear that the patch is in fact changing behaviour.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-04-09 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 11:24 Hui Tang
2021-04-09 7:33 ` Herbert Xu [this message]
2021-04-09 9:30 ` Hui Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409073334.GC23134@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tanghui20@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®