From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8755C43603 for ; Fri, 9 Apr 2021 16:45:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C20C8610CC for ; Fri, 9 Apr 2021 16:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234210AbhDIQqE (ORCPT ); Fri, 9 Apr 2021 12:46:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234201AbhDIQqC (ORCPT ); Fri, 9 Apr 2021 12:46:02 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E52ACC061760 for ; Fri, 9 Apr 2021 09:45:48 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id r22so7279381edq.9 for ; Fri, 09 Apr 2021 09:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=e/em5EuQEHT+Z/PGnvdzE9LeXg+II9Wp6x7IJLoWZ9w=; b=sftEeqGMQ73HmmfgNBNQ6lTc0oTCxDPRrt7cQWCEyZr+TLVCj9fj3HJ/qdoyx/Z3F/ 7DG1LAvqNivMSX6nGZVjNkwfNvh9dAJE78jI4NlIpexLR/s8dn/5gjHekcIQS4evE+dV MNTjt2EWSqUrKIs3O1EH+D/pj8whcIbgcnY8tf2jQke7jRpQRQZSkhxe//eGnwpvzo7L yhbuEiKDGWGxm9vjaU0i88rvuZmr7X+HO4dnJTuuM3uV1E7WzeTKGnZHLr+zc8xcfXpS Q8hJBpADbLarpYn/ubFkvHEAs4zIA/5MS5QrVeTwhSQwNtlm3A5rKN4fcd6tqPkjwG/6 VAhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=e/em5EuQEHT+Z/PGnvdzE9LeXg+II9Wp6x7IJLoWZ9w=; b=k+/qU0G2uP6K5EjMKsAs8uY0GFMy+5FTdu4fLJI61dE6xfdY61aONaM4h6GqbcbS2w PE0zZ/QNtBl8nXKz8oW6Qs69a7Nyia6NVUMWcAuA9zqSIUCTTCYuWBRwwzsMKD14daEj UYa70Y+VWFCtqi9SvIGQBr1bKQ4B61684xAAxKJsfyVwgoiTpQDfft1nk4WbMzKon94Q iLh82HPdN9k6U2mH+hTZqUImCHt5uoqHxkYIcvdP9bwtrx2eFWCT/Yw0JR3jXaeB62eS v1iS/j/JhoQvxhANQ+VsLt34p5GquHIrNj3rasVUW3hpMwRHYA5SLk/FUNnbz/Zvs4GJ 1llg== X-Gm-Message-State: AOAM530ADbsoYznkOkNsgroLnePqvxZBK85Gunr6dLTZS2B4r2mMKmeR SIkELwKd5jtU3SVivEEfyr/jBZDYkYir3wXs X-Google-Smtp-Source: ABdhPJwCYxiF0e5NsFjn6l+ySNyQHGBzCq2GEXx8piWA2Bw1y9SuYAbslkTc9gprovP5lc9CviQBgg== X-Received: by 2002:a05:6402:1857:: with SMTP id v23mr18127004edy.362.1617986747682; Fri, 09 Apr 2021 09:45:47 -0700 (PDT) Received: from localhost.localdomain (host-95-237-55-30.retail.telecomitalia.it. [95.237.55.30]) by smtp.gmail.com with ESMTPSA id dh27sm1706143edb.28.2021.04.09.09.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 09:45:47 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg KH , outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [Outreachy kernel] [PATCH 2/3] staging: rtl8723bs: Change the type and use of a variable Date: Fri, 9 Apr 2021 18:45:43 +0200 Message-Id: <20210409164543.30878-1-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change the type of fw_current_in_ps_mode from u8 to bool, because it is used everywhere as a bool and, accordingly, it should be declared as a bool. Shorten the controlling expression of an 'if' statement. Signed-off-by: Fabio M. De Francesco --- drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +- drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c index 96fe172ced8d..8dc4dd8c6d4c 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -348,7 +348,7 @@ void rtw_hal_dm_watchdog(struct adapter *padapter) void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter) { - if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode == true) { + if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode) { if (padapter->HalFunc.hal_dm_watchdog_in_lps) padapter->HalFunc.hal_dm_watchdog_in_lps(padapter); /* this function caller is in interrupt context */ } diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h index 5450d20b44a6..c03ae33b0aa6 100644 --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h @@ -203,7 +203,7 @@ struct pwrctrl_priv { u8 LpsIdleCount; u8 power_mgnt; u8 org_power_mgnt; - u8 fw_current_in_ps_mode; + bool fw_current_in_ps_mode; unsigned long DelayLPSLastTimeStamp; s32 pnp_current_pwr_state; u8 pnp_bstop_trx; -- 2.31.1