From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A9CFC433ED for ; Sat, 10 Apr 2021 01:53:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68F70611F1 for ; Sat, 10 Apr 2021 01:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234159AbhDJBxa (ORCPT ); Fri, 9 Apr 2021 21:53:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234085AbhDJBxW (ORCPT ); Fri, 9 Apr 2021 21:53:22 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 786B9C0613D8 for ; Fri, 9 Apr 2021 18:53:07 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id d124so5353177pfa.13 for ; Fri, 09 Apr 2021 18:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=TP/ej0A5oIbB+SZtsRxku6ynn0XFhltYZbU946pbzvENIPryBryzlCL8OsXZPO5/39 5wp3q/GEB1X8Vec131bV1WM0mwViEIKK3qoyRIirnHyTnuEvIpGVUefSgMxW8FVaiD9H IDhSM2hT9uM40D9RHJWn5U6LOvPEUXG0EI1M4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=GFje5/g1vjTe6Md6HJfWxdvQXH8FzHgcmlP9eij+C8RW+SVPfnCAQW5y8EE+BnGigH 7OYwrLkrKYeW2ti/8Wa09towtxsQ6u/Ngmdkb/OpoFvHugKpuu5GWPEgrMmnAuug+Z4o PJJOR/oKwq27atVkFxd8psl9t1nWtGT+yYs7e2yU/AqbKH0rnWXwlLSlPEKnMT2D+vz9 7dhAilI1x70GEreSF3GlJvxDp5FaABSfUryvZVMxZ8V/ywN2AnC0AoETskZmjLg7nk4s sUPT621pPhUT7G05QAiTfwMWHNVOQ4g4U9tPDASaNoElgq322WXWGhDiDx6nSOSBB3HK 1rXw== X-Gm-Message-State: AOAM530luXpyDJf9A2M1kS3+7lA6BJRTL2p84kUD8Jo6ayEClBzg5zzI Kf09vLFFRaIDIccMp2vRlTXznA== X-Google-Smtp-Source: ABdhPJw8ZEAEA342lhXIwD1tc1lC/gFPTrsFOOLwwizGLOeyoEtQpg+N0r26bdjfaqGjN5mMFbargw== X-Received: by 2002:a63:1820:: with SMTP id y32mr15990639pgl.157.1618019587023; Fri, 09 Apr 2021 18:53:07 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:5141:7881:7013:743b]) by smtp.gmail.com with ESMTPSA id n23sm3837962pgl.49.2021.04.09.18.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 18:53:06 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Andy Shevchenko , Matthew Wilcox Subject: [PATCH v4 06/13] arm64: stacktrace: Use %pSb for backtrace printing Date: Fri, 9 Apr 2021 18:52:53 -0700 Message-Id: <20210410015300.3764485-7-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.295.g9ea45b61b8-goog In-Reply-To: <20210410015300.3764485-1-swboyd@chromium.org> References: <20210410015300.3764485-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Catalin Marinas Cc: Will Deacon Cc: Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Matthew Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index ad20981dfda4..9d38da01ff98 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -129,7 +129,7 @@ NOKPROBE_SYMBOL(walk_stackframe); static void dump_backtrace_entry(unsigned long where, const char *loglvl) { - printk("%s %pS\n", loglvl, (void *)where); + printk("%s %pSb\n", loglvl, (void *)where); } void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk, -- https://chromeos.dev