From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D9AC433ED for ; Sat, 10 Apr 2021 01:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD9BE611F0 for ; Sat, 10 Apr 2021 01:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234260AbhDJBxd (ORCPT ); Fri, 9 Apr 2021 21:53:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234131AbhDJBxX (ORCPT ); Fri, 9 Apr 2021 21:53:23 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A230C0613D9 for ; Fri, 9 Apr 2021 18:53:08 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id n38so5399256pfv.2 for ; Fri, 09 Apr 2021 18:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UUQWTfijg1cAUQuQg/jqN0uOSlJ8iwcYRlNSG9SB/TU=; b=AIimY/rCAR/aUWtyJ2t2wANiXe5VkUMQQRwEdSCBWnpGsuTrpU/1oWHRYh43EjJufx Jfp2DqV/P/OGOnbF79EMEEXn09OL/zvW/53bWaOy/DtnItf2rLdhlvNLRrgWCsPXStC+ eueFlyJfKD+73OdUruEkMIGCm4joo4Yzugkis= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UUQWTfijg1cAUQuQg/jqN0uOSlJ8iwcYRlNSG9SB/TU=; b=Ib/UBonejCGEtX2yZ1XVMq0rqe8lbWzsqN27HQN6YrtnMfbfa5PHF6mImjID5kqB/D QQlQHNQuuzyCBIg1btpymcePo1KzM3TUW5iBImY8bXspauOrWyiCvT29/5fPcgGx8fcZ 1XuSFJPnYnINccfVB4V+tykry1J1NBTVL3shWHqXxtGQyYJ+CZhjBiwCgzK9+kVB7XAI Id1HFOayeq7NbYSkg0lPg4/OtuNRxBeOMr37DPE0cp0HHNUxuo4QlGH+/UrCcoR914aF BkyQ0F2+XzLzhFP0K2343utdOV8XRZVo/heQYFhdBc5gJxNOkXVOTioYSBKPm3xIDihH QOWA== X-Gm-Message-State: AOAM53201N0HReMm/Hz6D2dlGc97sVwmjxjKmpd8FVrGXaixPyAXtR6g xN2yRI83fPDhho3Axt8H5GodVw== X-Google-Smtp-Source: ABdhPJwKZMBcsAc59YGHuABKAPfV6l4KYnqWQf4Qp8UlVb9HwYa7Tz+TCtM5emHDoukIUiQ+vxi3fQ== X-Received: by 2002:a63:556:: with SMTP id 83mr16381598pgf.436.1618019587880; Fri, 09 Apr 2021 18:53:07 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:5141:7881:7013:743b]) by smtp.gmail.com with ESMTPSA id n23sm3837962pgl.49.2021.04.09.18.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 18:53:07 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Andy Shevchenko , Matthew Wilcox Subject: [PATCH v4 07/13] x86/dumpstack: Use %pSb/%pBb for backtrace printing Date: Fri, 9 Apr 2021 18:52:54 -0700 Message-Id: <20210410015300.3764485-8-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.295.g9ea45b61b8-goog In-Reply-To: <20210410015300.3764485-1-swboyd@chromium.org> References: <20210410015300.3764485-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's use the new printk formats to print the stacktrace entries when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Matthew Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- arch/x86/kernel/dumpstack.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index 299c20f0a38b..be2de39bf16f 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -69,7 +69,7 @@ static void printk_stack_address(unsigned long address, int reliable, const char *log_lvl) { touch_nmi_watchdog(); - printk("%s %s%pB\n", log_lvl, reliable ? "" : "? ", (void *)address); + printk("%s %s%pBb\n", log_lvl, reliable ? "" : "? ", (void *)address); } static int copy_code(struct pt_regs *regs, u8 *buf, unsigned long src, @@ -143,9 +143,9 @@ void show_opcodes(struct pt_regs *regs, const char *loglvl) void show_ip(struct pt_regs *regs, const char *loglvl) { #ifdef CONFIG_X86_32 - printk("%sEIP: %pS\n", loglvl, (void *)regs->ip); + printk("%sEIP: %pSb\n", loglvl, (void *)regs->ip); #else - printk("%sRIP: %04x:%pS\n", loglvl, (int)regs->cs, (void *)regs->ip); + printk("%sRIP: %04x:%pSb\n", loglvl, (int)regs->cs, (void *)regs->ip); #endif show_opcodes(regs, loglvl); } -- https://chromeos.dev