From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4ECEC43461 for ; Mon, 12 Apr 2021 16:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A84A561355 for ; Mon, 12 Apr 2021 16:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244684AbhDLQml (ORCPT ); Mon, 12 Apr 2021 12:42:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:37270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343631AbhDLQfi (ORCPT ); Mon, 12 Apr 2021 12:35:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 70FB86101B; Mon, 12 Apr 2021 16:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618244819; bh=LuXvPBRB+cV/CxpnLpPWOlY3a2ln1he/OSJi+cyPhD0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DvWbdpsUHi5H8L6SVT01ggswKwUxCHq6IRWvJjoNG7pCteG2f5ncLpmQQnVQjaXse 7HPBmly0D87oC5j4hXsv6CiVLTrd/t6DG8G+mLcH8aZhxyt4PE2+seAwArJM8/vjsA EHLV5uZa5z/bqRtxybatghqwEtLdMvdgifOayOQkeFj6j+umaBX0VYFY9qde4RkCns 7SGVqOju7qMQKPUIIrR6uKCYAumNylSAdEJs+XHKaV1UGrrWUDtw6yxZ+elWWfO7gh hWv9Val+8THpEaZCAl36zGXY8SOFd5uclP8Sr4Y4Ukac/P8V+9180AWzK7e5m1DJMk 1sIfowbPyN9nw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aditya Pakki , Santosh Shilimkar , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com Subject: [PATCH AUTOSEL 4.14 22/25] net/rds: Avoid potential use after free in rds_send_remove_from_sock Date: Mon, 12 Apr 2021 12:26:27 -0400 Message-Id: <20210412162630.315526-22-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210412162630.315526-1-sashal@kernel.org> References: <20210412162630.315526-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aditya Pakki [ Upstream commit 0c85a7e87465f2d4cbc768e245f4f45b2f299b05 ] In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource is freed and later under spinlock, causing potential use-after-free. Set the free pointer to NULL to avoid undefined behavior. Signed-off-by: Aditya Pakki Acked-by: Santosh Shilimkar Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/rds/message.c | 1 + net/rds/send.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/net/rds/message.c b/net/rds/message.c index 4318cc9b78f7..b6765ead733b 100644 --- a/net/rds/message.c +++ b/net/rds/message.c @@ -91,6 +91,7 @@ void rds_message_put(struct rds_message *rm) rds_message_purge(rm); kfree(rm); + rm = NULL; } } EXPORT_SYMBOL_GPL(rds_message_put); diff --git a/net/rds/send.c b/net/rds/send.c index 23f2d81e7967..3a8e1f72bf33 100644 --- a/net/rds/send.c +++ b/net/rds/send.c @@ -645,7 +645,7 @@ static void rds_send_remove_from_sock(struct list_head *messages, int status) unlock_and_drop: spin_unlock_irqrestore(&rm->m_rs_lock, flags); rds_message_put(rm); - if (was_on_sock) + if (was_on_sock && rm) rds_message_put(rm); } -- 2.30.2