From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60BCFC433ED for ; Mon, 12 Apr 2021 21:22:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4232F61278 for ; Mon, 12 Apr 2021 21:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245656AbhDLVXQ (ORCPT ); Mon, 12 Apr 2021 17:23:16 -0400 Received: from mga07.intel.com ([134.134.136.100]:37824 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245107AbhDLVXM (ORCPT ); Mon, 12 Apr 2021 17:23:12 -0400 IronPort-SDR: W+V1SKcO7tOCCMIN/6ssKpKaWoxgcFSYJVYOir8riin7+35mcLpUAvjRoDmyUIk3wLE9dJ6xcA ckVsch22Fvcg== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="258255043" X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="258255043" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 14:22:53 -0700 IronPort-SDR: w20xRPbCNHbZFV4m4XNmVa95UmIEMCg5aIdaO7+IhGBpJS5OGhALVd7CkDtoYszRuLy2sWGJpr Pclup8EAGWSg== X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="521337381" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 14:22:50 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id B5855200E8; Tue, 13 Apr 2021 00:22:48 +0300 (EEST) Date: Tue, 13 Apr 2021 00:22:48 +0300 From: Sakari Ailus To: Mitali Borkar Cc: bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in Subject: Re: [Outreachy kernel] Re: [PATCH 2/6] staging: media: intel-ipu3: preferred __aligned(size) over __attribute__aligned(size) Message-ID: <20210412212248.GN3@paasikivi.fi.intel.com> References: <20210412094315.GJ3@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mitali, On Mon, Apr 12, 2021 at 07:59:29PM +0530, Mitali Borkar wrote: > On Mon, Apr 12, 2021 at 12:43:15PM +0300, Sakari Ailus wrote: > > Hi Mitali, > > > > On Mon, Apr 12, 2021 at 04:38:59AM +0530, Mitali Borkar wrote: > > > This patch fixes the warning identified by checkpatch.pl by replacing > > > __attribute__aligned(size) with __aligned(size) > > > > Same comments on this than the 1st patch. > > > > It's a staging driver so even if this is a user space header, it's not > > under include/uapi/linux. > > > Sir, I am not able to understandd what you are trying to say in this. As you > mentioned in patch 1/6, I removed and added header where BIT() macro under > apprpriate userpace, but what should I modify in this patch? The comment on the 1st patch and above was a weird way of saying "please drop patches 1 and 2". BIT(), __aligned() and __packed are macros in kernel headers that generally are not available in headers exported for user space consumption. -- Kind regards, Sakari Ailus