From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8654C433ED for ; Tue, 13 Apr 2021 16:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1CFE6128E for ; Tue, 13 Apr 2021 16:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344500AbhDMQ22 (ORCPT ); Tue, 13 Apr 2021 12:28:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:48804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343767AbhDMQ20 (ORCPT ); Tue, 13 Apr 2021 12:28:26 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD61A61220; Tue, 13 Apr 2021 16:28:05 +0000 (UTC) Date: Tue, 13 Apr 2021 12:28:04 -0400 From: Steven Rostedt To: Dietmar Eggemann Cc: Hui Su , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched: remove the redundant comments Message-ID: <20210413122804.2d69fca6@gandalf.local.home> In-Reply-To: References: <20210412073928.1120823-1-suhui@zeku.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Apr 2021 10:36:07 +0200 Dietmar Eggemann wrote: > > @@ -897,11 +897,6 @@ DECLARE_STATIC_KEY_FALSE(sched_uclamp_used); > > struct rq { > > /* runqueue lock: */ > > raw_spinlock_t lock; > > - > > - /* > > - * nr_running and cpu_load should be in the same cacheline because > > - * remote CPUs use both these fields when doing load calculation. > > - */ > > unsigned int nr_running; > > #ifdef CONFIG_NUMA_BALANCING > > unsigned int nr_numa_running; > > I forgot to remove this snippet back then. LGTM. > > Add a > > Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]") > > line. It's just removing a comment. Should it really need a "Fixes" tag, which will cause many people to look at it to determine if it should be backported to stable? -- Steve