From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38137C433B4 for ; Wed, 14 Apr 2021 04:46:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 154E5611F2 for ; Wed, 14 Apr 2021 04:46:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236743AbhDNEqt (ORCPT ); Wed, 14 Apr 2021 00:46:49 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:35064 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230249AbhDNEqr (ORCPT ); Wed, 14 Apr 2021 00:46:47 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13E4hxvi086440; Wed, 14 Apr 2021 04:46:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=sBmVwPsNeAH002CQeWCF/beRIkPh7vCoNYOX97ndJSw=; b=RRr2rJ6pDvOIiCYkItz04uDIiezUY5jFqUouHMBnwUVU7wvwPws5aOj+SZ5Wde/XVoVn dXsc2/VcB8ukOhi3XfZzONNGLcm12kqbEIKmVNBBB39RdbhBnTkPb/K9AIcneL5vkElN vovUyk244ONxAJXxxwMoyVo2jC+q4ElmhMyBfP+5RGdzgyQQxMT/u3NzzsrnK2p3dYrs C55K5UWWesr+lnecDh5KTnv8Et7YiGrhUTVA/3Pf3zEqwrO8473QqO7z3DDFkxiUeYfR 77vrN7aDEnF3NGZOI5VDMbFWFhDbNrPpg42klBoXZ83irSzEtI3wn4e6/JKmRe3ZrOcc ZA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 37u3erh2f4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Apr 2021 04:46:17 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13E4aWKN044042; Wed, 14 Apr 2021 04:46:15 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 37unkqfy2w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Apr 2021 04:46:15 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 13E4kEeQ030084; Wed, 14 Apr 2021 04:46:14 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 13 Apr 2021 21:46:13 -0700 Date: Wed, 14 Apr 2021 07:46:07 +0300 From: Dan Carpenter To: "Fabio M. De Francesco" Cc: outreachy-kernel@googlegroups.com, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove four set but not used variables Message-ID: <20210414044607.GN6021@kadam> References: <20210413184222.19539-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210413184222.19539-1-fmdefrancesco@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9953 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104140030 X-Proofpoint-ORIG-GUID: SEk8t2KZyBBIMFyhEhdRw9-czFb0Vay5 X-Proofpoint-GUID: SEk8t2KZyBBIMFyhEhdRw9-czFb0Vay5 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9953 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 clxscore=1031 adultscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 impostorscore=0 suspectscore=0 mlxscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104140031 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 08:42:22PM +0200, Fabio M. De Francesco wrote: > Removed four variables that were set but not used. > > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > index 77f8353c5ce5..fad6a3bfe07c 100644 > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > @@ -3199,12 +3199,10 @@ static void hw_var_set_mlme_join(struct adapter *padapter, u8 variable, u8 *val) > > void CCX_FwC2HTxRpt_8723b(struct adapter *padapter, u8 *pdata, u8 len) > { > - u8 seq_no; > > #define GET_8723B_C2H_TX_RPT_LIFE_TIME_OVER(_Header) LE_BITS_TO_1BYTE((_Header + 0), 6, 1) > #define GET_8723B_C2H_TX_RPT_RETRY_OVER(_Header) LE_BITS_TO_1BYTE((_Header + 0), 7, 1) > > - seq_no = *(pdata+6); > > if (GET_8723B_C2H_TX_RPT_RETRY_OVER(pdata) | GET_8723B_C2H_TX_RPT_LIFE_TIME_OVER(pdata)) { Now we have two blank lines in a row. Please delete one. regards, dan carpenter