From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE1EBC433ED for ; Wed, 14 Apr 2021 05:16:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72ED8613D7 for ; Wed, 14 Apr 2021 05:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345143AbhDNFQu (ORCPT ); Wed, 14 Apr 2021 01:16:50 -0400 Received: from mga11.intel.com ([192.55.52.93]:50443 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230375AbhDNFQt (ORCPT ); Wed, 14 Apr 2021 01:16:49 -0400 IronPort-SDR: vzT9Y5k00UbXofXnel46hwqpXnxr3LIjLc/y1eWma/i5HQVp9YIQWUpEvvTGuhT+zds+dpf1rX 2/tN39lU8J3Q== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="191381225" X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="191381225" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 22:16:28 -0700 IronPort-SDR: zIn7yGIa9lzVw7ZoIYGOoRquID06vW5z2PwC0CI3JOuJq4rstXq9N4aywsatHcI9CZ5iyu8cpL mccfmSYC9/aw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="600664550" Received: from lkp-server01.sh.intel.com (HELO 69d8fcc516b7) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 13 Apr 2021 22:16:25 -0700 Received: from kbuild by 69d8fcc516b7 with local (Exim 4.92) (envelope-from ) id 1lWXt2-0001aE-Oi; Wed, 14 Apr 2021 05:16:24 +0000 Date: Wed, 14 Apr 2021 13:15:33 +0800 From: kernel test robot To: Namhyung Kim , Peter Zijlstra Cc: kbuild-all@lists.01.org, Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa , Mark Rutland , Alexander Shishkin , LKML , Stephane Eranian , Andi Kleen , Ian Rogers Subject: [PATCH] perf/core: fix memdup_user.cocci warnings Message-ID: <20210414051533.GA94059@4510e896ae82> References: <20210413044133.617921-2-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210413044133.617921-2-namhyung@kernel.org> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot kernel/events/core.c:5925:13-20: WARNING opportunity for memdup_user Use memdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Generated by: scripts/coccinelle/api/memdup_user.cocci CC: Namhyung Kim Reported-by: kernel test robot Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Namhyung-Kim/perf-core-Sharing-events-with-multiple-cgroups/20210413-124251 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git cface0326a6c2ae5c8f47bd466f07624b3e348a7 core.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -5922,15 +5922,9 @@ static long _perf_ioctl(struct perf_even cgrp_bufsz = nr_cgrps * sizeof(*cgrp_buf); - cgrp_buf = kmalloc(cgrp_bufsz, GFP_KERNEL); - if (cgrp_buf == NULL) - return -ENOMEM; - - if (copy_from_user(cgrp_buf, (u64 __user *)(arg + 8), - cgrp_bufsz)) { - kfree(cgrp_buf); - return -EFAULT; - } + cgrp_buf = memdup_user((u64 __user *)(arg + 8), cgrp_bufsz); + if (IS_ERR(cgrp_buf)) + return PTR_ERR(cgrp_buf); ret = perf_event_attach_cgroup_node(event, nr_cgrps, cgrp_buf);