From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E7D8C433B4 for ; Wed, 14 Apr 2021 08:50:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E778D600D4 for ; Wed, 14 Apr 2021 08:50:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350210AbhDNIuk (ORCPT ); Wed, 14 Apr 2021 04:50:40 -0400 Received: from mga09.intel.com ([134.134.136.24]:43393 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244803AbhDNIuf (ORCPT ); Wed, 14 Apr 2021 04:50:35 -0400 IronPort-SDR: 9P4sCaVcIkhEGipDuK81dxmTWOC8qe0pbFxQ04f7Ef1zU40AZ/nH+z2HsTeGNvJWE8VYxgfJpW iGjZQY178qWw== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="194709272" X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="asc'?scan'208";a="194709272" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 01:50:14 -0700 IronPort-SDR: PhnCozf8UEFW4UKr5HkHWVFHrUZnwzlL5liJMxVYioxCDwDp1Ia1ghsUam5JRrwtgLBrVYSj2v Dzotrex2mzTg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="asc'?scan'208";a="450722624" Received: from zhen-hp.sh.intel.com (HELO zhen-hp) ([10.239.160.147]) by FMSMGA003.fm.intel.com with ESMTP; 14 Apr 2021 01:50:11 -0700 Date: Wed, 14 Apr 2021 16:32:21 +0800 From: Zhenyu Wang To: Jiapeng Chong Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org, joonas.lahtinen@linux.intel.com, linux-kernel@vger.kernel.org, jani.nikula@linux.intel.com, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, rodrigo.vivi@intel.com, intel-gvt-dev@lists.freedesktop.org, zhi.a.wang@intel.com Subject: Re: [PATCH] drm/i915/gvt: remove useless function Message-ID: <20210414083221.GN1551@zhen-hp.sh.intel.com> Reply-To: Zhenyu Wang References: <1618294728-78952-1-git-send-email-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ctZH5Gqgrl5HoVnD" Content-Disposition: inline In-Reply-To: <1618294728-78952-1-git-send-email-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ctZH5Gqgrl5HoVnD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021.04.13 14:18:48 +0800, Jiapeng Chong wrote: > Fix the following clang warning: >=20 > drivers/gpu/drm/i915/gvt/gtt.c:590:20: warning: unused function > 'ppgtt_set_guest_root_entry' [-Wunused-function]. >=20 > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/gpu/drm/i915/gvt/gtt.c | 6 ------ > 1 file changed, 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gt= t.c > index 897c007..a01ff44 100644 > --- a/drivers/gpu/drm/i915/gvt/gtt.c > +++ b/drivers/gpu/drm/i915/gvt/gtt.c > @@ -587,12 +587,6 @@ static void _ppgtt_set_root_entry(struct intel_vgpu_= mm *mm, > entry, index, false, 0, mm->vgpu); > } > =20 > -static inline void ppgtt_set_guest_root_entry(struct intel_vgpu_mm *mm, > - struct intel_gvt_gtt_entry *entry, unsigned long index) > -{ > - _ppgtt_set_root_entry(mm, entry, index, true); > -} > - > static inline void ppgtt_set_shadow_root_entry(struct intel_vgpu_mm *mm, > struct intel_gvt_gtt_entry *entry, unsigned long index) > { > --=20 Reviewed-by: Zhenyu Wang Thanks for covering me on this! Queue this up. --ctZH5Gqgrl5HoVnD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCYHaokAAKCRCxBBozTXgY J332AJ4salQYvYttCagxF7P2YWnt4+5OtACfSsWoYZp+DqERU/BbGvS+EbPHckI= =oqD8 -----END PGP SIGNATURE----- --ctZH5Gqgrl5HoVnD--