From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: julia.lawall@inria.fr, joe@perches.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()
Date: Wed, 14 Apr 2021 11:43:41 +0200 [thread overview]
Message-ID: <20210414094340.GB3931@agape.jhs> (raw)
In-Reply-To: <YHanGdS1Kc/4zq4q@kroah.com>
On Wed, Apr 14, 2021 at 10:26:01AM +0200, Greg KH wrote:
> > - DBG_871X_SEL_NL(sel, "%10s %16s %8s %10s %11s %14s\n",
> > - "TH_L2H_ini", "TH_EDCCA_HL_diff", "IGI_Base",
> > - "ForceEDCCA", "AdapEn_RSSI", "IGI_LowerBound");
> > - DBG_871X_SEL_NL(sel, "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n",
> > - (u8)odm->TH_L2H_ini,
> > - odm->TH_EDCCA_HL_diff,
> > - odm->IGI_Base,
> > - odm->ForceEDCCA,
> > - odm->AdapEn_RSSI,
> > - odm->IGI_LowerBound
> > - );
> > + netdev_dbg(adapter->pnetdev, "%10s %16s %8s %10s %11s %14s\n",
> > + "TH_L2H_ini", "TH_EDCCA_HL_diff", "IGI_Base", "ForceEDCCA",
> > + "AdapEn_RSSI", "IGI_LowerBound");netdev_dbg(adapter->pnetdev,
> > + "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n",
> > + (u8)odm->TH_L2H_ini,
> > + odm->TH_EDCCA_HL_diff,
> > + odm->IGI_Base,
> > + odm->ForceEDCCA,
> > + odm->AdapEn_RSSI,
> > + odm->IGI_LowerBound);
>
> Something went wrong with this change :(
thanks Greg, I sent an example to Julia, that reproduce the problem.
As soon as it gets fixed I will send you a v2.
fabio
next prev parent reply other threads:[~2021-04-14 9:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 14:56 [PATCH 0/7] staging: rtl8723bs: replace DBG_871X_SEL_NL macro " Fabio Aiuto
2021-04-13 14:56 ` [PATCH 1/7] staging: rtl8723bs: replace dump_drv_version() usage " Fabio Aiuto
2021-04-13 14:56 ` [PATCH 2/7] staging: rtl8723bs: remove unnecessary dump_drv_version() usage Fabio Aiuto
2021-04-13 14:56 ` [PATCH 3/7] staging: rtl8723bs: remove two unused functions Fabio Aiuto
2021-04-13 14:56 ` [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg() Fabio Aiuto
2021-04-14 8:26 ` Greg KH
2021-04-14 9:43 ` Fabio Aiuto [this message]
2021-04-14 10:28 ` Greg KH
2021-04-13 14:56 ` [PATCH 5/7] staging: rtl8723bs: put a new line after ';' Fabio Aiuto
2021-04-14 8:25 ` Greg KH
2021-04-13 14:56 ` [PATCH 6/7] staging: rtl8723bs: remove DBG_871X_SEL_NL macro declaration Fabio Aiuto
2021-04-13 14:56 ` [PATCH 7/7] staging: rtl8723bs: remove unused argument in function Fabio Aiuto
-- strict thread matches above, loose matches on Subject: below --
2021-04-13 14:10 [PATCH 0/7] staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg() Fabio Aiuto
2021-04-13 14:10 ` [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL " Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414094340.GB3931@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®