From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E78CC433ED for ; Wed, 14 Apr 2021 18:33:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED49F61107 for ; Wed, 14 Apr 2021 18:33:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353019AbhDNSeI (ORCPT ); Wed, 14 Apr 2021 14:34:08 -0400 Received: from mga01.intel.com ([192.55.52.88]:37897 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352895AbhDNSdx (ORCPT ); Wed, 14 Apr 2021 14:33:53 -0400 IronPort-SDR: MJC7Aw7DXwX60FJUdz0de0aQDW2h3rGO8m6mmHdRzfGvvc3CwyAwlT0+feBIViATfN23kAGsyp BbDR96jjSlyw== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="215202614" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="215202614" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 11:33:30 -0700 IronPort-SDR: QWUsGFJgdDqPIdf8WgwLE3snSAtlxd3nPW6cEcKKnSYoIgIfBTbFPG31qYfmXL+6RRgisHlsrP VPUpMILwql3Q== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="532871296" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 11:33:28 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id E85DD200E8; Wed, 14 Apr 2021 21:33:25 +0300 (EEST) Date: Wed, 14 Apr 2021 21:33:25 +0300 From: Sakari Ailus To: Aline Santana Cordeiro Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp_cmd.c Message-ID: <20210414183325.GD3@paasikivi.fi.intel.com> References: <20210414182755.GA2799@focaruja> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414182755.GA2799@focaruja> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Aline, Thanks for the patch. On Wed, Apr 14, 2021 at 03:27:55PM -0300, Aline Santana Cordeiro wrote: > Format multi-line comments according to the coding-style. > Issue detected by checkpatch.pl. > > Signed-off-by: Aline Santana Cordeiro > --- > drivers/staging/media/atomisp/pci/atomisp_cmd.c | 109 ++++++++++++++---------- > 1 file changed, 65 insertions(+), 44 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c > index 592ea99..6113785 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c > @@ -67,7 +67,8 @@ > * At 15fps this means 133ms. We set the timeout a bit longer. > * Each flash driver is supposed to set its own timeout, but > * just in case someone else changed the timeout, we set it > - * here to make sure we don't damage the flash hardware. */ > + * here to make sure we don't damage the flash hardware. > + */ > #define FLASH_TIMEOUT 800 /* ms */ > > union host { > @@ -562,7 +563,8 @@ irqreturn_t atomisp_isr(int irq, void *dev) > * and driver needs to keep old sequence_temp value. > * NOTE: There is assumption here that ISP will not > * start processing next frame from sensor before old > - * one is completely done. */ > + * one is completely done. > + */ > if (atomic_read(&asd->sequence) == atomic_read( > &asd->sequence_temp)) > atomic_set(&asd->sequence_temp, > @@ -1247,7 +1249,8 @@ void atomisp_buf_done(struct atomisp_sub_device *asd, int error, > > if (IS_ISP2401) { > /* If there are no buffers queued then This should begin with: /* * And the same for the rest. Apart from this the patch seems fine. -- Kind regards, Sakari Ailus