From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F8EC433B4 for ; Thu, 15 Apr 2021 05:56:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0663261431 for ; Thu, 15 Apr 2021 05:56:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230439AbhDOF4e (ORCPT ); Thu, 15 Apr 2021 01:56:34 -0400 Received: from verein.lst.de ([213.95.11.211]:33313 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230419AbhDOF4a (ORCPT ); Thu, 15 Apr 2021 01:56:30 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id F1E3A68BEB; Thu, 15 Apr 2021 07:56:05 +0200 (CEST) Date: Thu, 15 Apr 2021 07:56:05 +0200 From: Christoph Hellwig To: Palmer Dabbelt Cc: Damien Le Moal , viro@zeniv.linux.org.uk, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, jcmvbkbc@gmail.com, gerg@linux-m68k.org, Anup Patel , Christoph Hellwig , uclinux-dev@uclinux.org Subject: Re: [PATCH v2 0/2] Fix binfmt_flat loader for RISC-V Message-ID: <20210415055605.GB8947@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org binfmt_flat tends to go through Greg's uclinux tree, adding him and the list. On Wed, Apr 14, 2021 at 10:46:36PM -0700, Palmer Dabbelt wrote: > On Wed, 14 Apr 2021 17:32:10 PDT (-0700), Damien Le Moal wrote: >>> On 2021/04/08 0:49, Damien Le Moal wrote: >>> RISC-V NOMMU flat binaries cannot tolerate a gap between the text and >>> data section as the toolchain fully resolves at compile time the PC >>> relative global pointer (__global_pointer$ value loaded in gp register). >>> Without a relocation entry provided, the flat bin loader cannot fix the >>> value if a gap is introduced and executables fail to run. >>> >>> This series fixes this problem by allowing an architecture to request >>> the flat loader to suppress the gap between the text and data sections. >>> The first patch fixes binfmt_flat flat_load_file() using the new >>> configuration option CONFIG_BINFMT_FLAT_NO_TEXT_DATA_GAP. The second >>> patch enables this option for RISCV NOMMU builds. >>> >>> These patches do not change the binfmt_flat loader behavior for other >>> architectures. >>> >>> Changes from v1: >>> * Replace FLAT_TEXT_DATA_NO_GAP macro with >>> CONFIG_BINFMT_FLAT_NO_TEXT_DATA_GAP config option (patch 1). >>> * Remove the addition of riscv/include/asm/flat.h and set >>> CONFIG_BINFMT_FLAT_NO_TEXT_DATA_GAP for RISCV and !MMU >>> >>> Damien Le Moal (2): >>> binfmt_flat: allow not offsetting data start >>> riscv: Disable text-data gap in flat binaries >>> >>> arch/riscv/Kconfig | 1 + >>> fs/Kconfig.binfmt | 3 +++ >>> fs/binfmt_flat.c | 21 +++++++++++++++------ >>> 3 files changed, 19 insertions(+), 6 deletions(-) >>> >> >> Ping ? >> >> Any comment on these patches ? >> >> Without them, RISC-V NOMMU user space does not run... I would really like to get >> these in this cycle if possible. > > This LGTM, but it's pretty far out of my area of expertise. I'm happy to > take them via my tree, but I'd prefer to get an Ack from someone. > > Al, get_maintainer suggests you? > > Acked-by: Palmer Dabbelt ---end quoted text---