From: Herbert Xu <herbert@gondor.apana.org.au>
To: Hui Tang <tanghui20@huawei.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
xuzaibo@huawei.com, wangzhou1@hisilicon.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] crypto: hisilicon/hpre - delete redundant log and return in advance
Date: Fri, 16 Apr 2021 21:33:26 +1000 [thread overview]
Message-ID: <20210416113326.GO16633@gondor.apana.org.au> (raw)
In-Reply-To: <1618048232-12634-1-git-send-email-tanghui20@huawei.com>
On Sat, Apr 10, 2021 at 05:50:32PM +0800, Hui Tang wrote:
> 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
> necessary to do it here, so remove it.
>
> It should return error immediately when return value of 'hpre_cfg_by_dsm'
> is non-zero, and no need to execute the remaining sentences.
>
> Signed-off-by: Hui Tang <tanghui20@huawei.com>
>
> ---
> v1 -> v2:
> - Return immediately when return value of 'hpre_cfg_by_dsm' is
> non-zero.
> v2 -> v3:
> - Add description for return if function fails.
> ---
> drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-04-16 11:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 9:50 Hui Tang
2021-04-16 11:33 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416113326.GO16633@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tanghui20@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®