From: Bjorn Helgaas <helgaas@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: shpchp: remove unused function
Date: Fri, 16 Apr 2021 11:23:44 -0500 [thread overview]
Message-ID: <20210416162344.GA2724691@bjorn-Precision-5520> (raw)
In-Reply-To: <1618475422-96531-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Thu, Apr 15, 2021 at 04:30:22PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/pci/hotplug/shpchp_hpc.c:177:20: warning: unused function
> 'shpc_writeb' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Applied to pci/hotplug for v5.13 with the following subject, thanks!
PCI: shpchp: Remove unused shpc_writeb()
> ---
> drivers/pci/hotplug/shpchp_hpc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
> index db04728..9e3b277 100644
> --- a/drivers/pci/hotplug/shpchp_hpc.c
> +++ b/drivers/pci/hotplug/shpchp_hpc.c
> @@ -174,11 +174,6 @@ static inline u8 shpc_readb(struct controller *ctrl, int reg)
> return readb(ctrl->creg + reg);
> }
>
> -static inline void shpc_writeb(struct controller *ctrl, int reg, u8 val)
> -{
> - writeb(val, ctrl->creg + reg);
> -}
> -
> static inline u16 shpc_readw(struct controller *ctrl, int reg)
> {
> return readw(ctrl->creg + reg);
> --
> 1.8.3.1
>
prev parent reply other threads:[~2021-04-16 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 8:30 Jiapeng Chong
2021-04-15 13:33 ` Krzysztof Wilczyński
2021-04-16 16:23 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416162344.GA2724691@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®