From: Alexander Egorenkov <egorenar-dev@posteo.net>
To: linux-kernel@vger.kernel.org
Cc: Alexander Egorenkov <egorenar-dev@posteo.net>
Subject: [PATCH 1/2] lib: scatterlist: Fix loop termination condition in sg_calculate_split()
Date: Sun, 18 Apr 2021 14:34:24 +0000 [thread overview]
Message-ID: <20210418143425.22944-1-egorenar-dev@posteo.net> (raw)
nb_splits was decremented one time too much becoming negative. This
leads to the failure of the loop termination conditions which checks
only for nb_splits being zero. Move the loop termination condition
a couple of lines up before nb_splits is decremented again and potentially
becomes negative.
Signed-off-by: Alexander Egorenkov <egorenar-dev@posteo.net>
---
lib/sg_split.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/lib/sg_split.c b/lib/sg_split.c
index 3d9b32084d78..0920affd12ee 100644
--- a/lib/sg_split.c
+++ b/lib/sg_split.c
@@ -60,15 +60,16 @@ static int sg_calculate_split(struct scatterlist *in, int nents, int nb_splits,
curr->length_last_sg = len;
size -= len;
}
- skip = 0;
-
- if (!size && --nb_splits > 0) {
- curr++;
- size = *(++sizes);
- }
if (!nb_splits)
break;
+
+ skip = 0;
+
+ if (!size && --nb_splits > 0) {
+ curr++;
+ size = *(++sizes);
+ }
}
return (size || !splitters[0].in_sg0) ? -EINVAL : 0;
--
2.31.1
next reply other threads:[~2021-04-18 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 14:34 Alexander Egorenkov [this message]
2021-04-18 14:34 ` [PATCH 2/2] lib: scatterlist: Fix incorrect SG offset in sg_split_phys() Alexander Egorenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210418143425.22944-1-egorenar-dev@posteo.net \
--to=egorenar-dev@posteo.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®