From: Ashish Kalra <eashishkalra@gmail.com>
To: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Ashish Kalra <eashishkalra@gmail.com>
Subject: Re: [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning
Date: Mon, 19 Apr 2021 22:26:59 +0530 [thread overview]
Message-ID: <20210419165659.GA2363@ashish-NUC8i5BEH> (raw)
In-Reply-To: <3163466.7bx4QQXRp1@pc-42>
On Mon, Apr 19, 2021 at 05:55:34PM +0200, Jérôme Pouiller wrote:
> On Monday 19 April 2021 17:33:48 CEST Ashish Kalra wrote:
> >
> > Upon running sparse, "warning: symbol 'wfx_get_ps_timeout' was not declared.
> > Should it be static?" and "warning: symbol 'wfx_update_pm' was not declared.
> > Should it be static?" is brought to notice for this file. static keyword
> > should be added to prevent this warning. let's add it to make it cleaner and
> > silence the Sparse warning.
>
> Hi Ashish,
>
> Thank you for your contribution.
>
> It seems that this issue is already fixed by commit ce59858bbc10 "staging:
> wfx: make methods 'wfx_get_ps_timeout' and 'wfx_update_pm' static" (merged
> in master in version 5.8). Can you check you are working on the last tree?
>
>
> --
> Jérôme Pouiller
>
>
Thanks Jerome
It seems some sync issue with my source code.I will update to
latest and correct
prev parent reply other threads:[~2021-04-19 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 15:33 Ashish Kalra
2021-04-19 15:55 ` Jérôme Pouiller
2021-04-19 16:56 ` Ashish Kalra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419165659.GA2363@ashish-NUC8i5BEH \
--to=eashishkalra@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jerome.pouiller@silabs.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®