From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1722C433B4 for ; Tue, 20 Apr 2021 17:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4E95613B8 for ; Tue, 20 Apr 2021 17:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233398AbhDTRZ3 (ORCPT ); Tue, 20 Apr 2021 13:25:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232913AbhDTRZ3 (ORCPT ); Tue, 20 Apr 2021 13:25:29 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76E5DC06174A for ; Tue, 20 Apr 2021 10:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=zCxTkutdwyOxu0wuqOhdUR3tApRYoORPLDIdB78sc9k=; b=QM6uZMU5YdM5DjGzJQhdeM3pv1 buG8WwmUrUJNsBuLqit6NqlnwHAmc+d3keBcejm7UHxHI+F5+XT+C2PbqMc6t2HsRprGOil4dLINr X+cAlvF7p2vK9jlU1/KsfiyiRkQBH4wChvW4MonH/aqZ+m4+t1cfVlW+IPEnkmtnwSASPJtTjygNZ Z20u5l38xJaHZyUfpjGn7XBrEKHObYPJ6sFJomJ475sSZtFUoOrvVbwIVMGx/gL9ZXLw3mjjQ/0Pu WP50QCPqMWkR/i4rTIo5L80qAGL0sY1MLPKHA0uEKTmCk/FhlewqOjOqiK6Y0E4wBTNxFjI8cthF0 wD3xhtDQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lYu5H-00FR6u-Or; Tue, 20 Apr 2021 17:23:13 +0000 From: "Matthew Wilcox (Oracle)" To: Catalin Marinas , Will Deacon , Mark Rutland , Peter Zijlstra , Kees Cook , Marc Zyngier , Vincenzo Frascino Cc: "Matthew Wilcox (Oracle)" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm64: Show three registers per line Date: Tue, 20 Apr 2021 18:22:45 +0100 Message-Id: <20210420172245.3679077-1-willy@infradead.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Displaying two registers per line takes 15 lines. That improves to just 10 lines if we display three registers per line, which reduces the amount of information lost when oopses are cut off. It stays within 80 columns and matches x86-64. Signed-off-by: Matthew Wilcox (Oracle) --- arch/arm64/kernel/process.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 6e60aa3b5ea9..aff5a2c12297 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -294,13 +294,10 @@ void __show_regs(struct pt_regs *regs) i = top_reg; while (i >= 0) { - printk("x%-2d: %016llx ", i, regs->regs[i]); - i--; + printk("x%-2d: %016llx", i, regs->regs[i]); - if (i % 2 == 0) { - pr_cont("x%-2d: %016llx ", i, regs->regs[i]); - i--; - } + while (i-- % 3) + pr_cont(" x%-2d: %016llx", i, regs->regs[i]); pr_cont("\n"); } -- 2.30.2