From: kernel test robot <rong.a.chen@intel.com>
To: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Sebastian Reichel <sre@kernel.org>
Subject: drivers/power/supply/bq256xx_charger.c:346:12: warning: Identical inner 'if' condition is always true. [identicalInnerCondition]
Date: Wed, 21 Apr 2021 09:59:18 +0800 [thread overview]
Message-ID: <20210421015918.GM1780177@shao2-debian> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7af08140979a6e7e12b78c93b8625c8d25b084e2
commit: 32e4978bb920d047fe5de3ea42d176f267c01f63 power: supply: bq256xx: Introduce the BQ256XX charger driver
date: 3 months ago
compiler: mips64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/power/supply/bq256xx_charger.c:346:12: warning: Identical inner 'if' condition is always true. [identicalInnerCondition]
if (val < array[i])
^
drivers/power/supply/bq256xx_charger.c:345:33: note: outer condition: val<array[i]
if (val > array[i - 1] && val < array[i]) {
^
drivers/power/supply/bq256xx_charger.c:346:12: note: identical inner condition: val<array[i]
if (val < array[i])
^
vim +/if +346 drivers/power/supply/bq256xx_charger.c
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 330
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 331 static int bq256xx_array_parse(int array_size, int val, const int array[])
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 332 {
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 333 int i = 0;
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 334
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 335 if (val < array[i])
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 336 return i - 1;
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 337
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 338 if (val >= array[array_size - 1])
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 339 return array_size - 1;
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 340
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 341 for (i = 1; i < array_size; i++) {
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 342 if (val == array[i])
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 343 return i;
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 344
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 345 if (val > array[i - 1] && val < array[i]) {
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 @346 if (val < array[i])
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 347 return i - 1;
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 348 else
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 349 return i;
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 350 }
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 351 }
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 352 return -EINVAL;
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 353 }
32e4978bb920d0 Ricardo Rivera-Matos 2021-01-06 354
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
reply other threads:[~2021-04-21 2:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421015918.GM1780177@shao2-debian \
--to=rong.a.chen@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=r-rivera-matos@ti.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®