From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9463BC433B4 for ; Thu, 22 Apr 2021 05:16:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AEC7613F6 for ; Thu, 22 Apr 2021 05:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231539AbhDVFRV (ORCPT ); Thu, 22 Apr 2021 01:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbhDVFRT (ORCPT ); Thu, 22 Apr 2021 01:17:19 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0389EC06174A for ; Wed, 21 Apr 2021 22:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=9lqRM0u7jk+d4p6NEuHBBQT7nVxtfUYc+9AYmsJLxtA=; b=cmJpmVZxUactN+9KZClzROXLsz AQfBSx8CiVSpJ58s3/sWEyboOdmMYV00Uqf7v9e7jHo4wm+s31D3XIaa3cendo4ebA1Hyqs0lthiW UokHRB7vxlzzcPWbfgtGDcyR6bisdzcIBEZwpKOBeGu4ux6AdNTeXNitCb9dqLLeQIEguC2hSoIW4 1OZE2bBYRnh8iVAMO0DLBtC7CBqKzQQpUJCxz0yNGfoKBa32VO/jZhka6+TDGuNNZRC3TAFl77/l7 hrr6Dblk03TOjhSKVFeJ8z8Q9yrAIzIY7TueeVAoHyitwuE3r5Jd2FGebzlvYIKlR2tphumCGoiU5 8Yi1h19w==; Received: from [2601:1c0:6280:3f0::df68] (helo=smtpauth.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lZRhQ-00HSuZ-1U; Thu, 22 Apr 2021 05:16:33 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Thomas Gleixner , Marc Zyngier , Christian Ruppert Subject: [PATCH] irqchip: tb10x: use 'fallthrough' to eliminate a warning Date: Wed, 21 Apr 2021 22:16:20 -0700 Message-Id: <20210422051620.23021-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the 'fallthrough' macro to document that this switch case does indeed fall through to the next case. ../drivers/irqchip/irq-tb10x.c: In function 'tb10x_irq_set_type': ../drivers/irqchip/irq-tb10x.c:62:13: warning: this statement may fall through [-Wimplicit-fallthrough=] 62 | flow_type = IRQ_TYPE_LEVEL_LOW; ../drivers/irqchip/irq-tb10x.c:63:2: note: here 63 | case IRQ_TYPE_LEVEL_LOW: | ^~~~ Fixes: b06eb0173ef1 ("irqchip: Add TB10x interrupt controller driver") Signed-off-by: Randy Dunlap Cc: Thomas Gleixner Cc: Marc Zyngier Cc: Christian Ruppert --- drivers/irqchip/irq-tb10x.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20210420.orig/drivers/irqchip/irq-tb10x.c +++ linux-next-20210420/drivers/irqchip/irq-tb10x.c @@ -60,6 +60,7 @@ static int tb10x_irq_set_type(struct irq break; case IRQ_TYPE_NONE: flow_type = IRQ_TYPE_LEVEL_LOW; + fallthrough; case IRQ_TYPE_LEVEL_LOW: mod ^= im; pol ^= im;