From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5041BC43460 for ; Thu, 22 Apr 2021 16:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 217C461407 for ; Thu, 22 Apr 2021 16:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236634AbhDVQNS (ORCPT ); Thu, 22 Apr 2021 12:13:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:55170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236504AbhDVQNQ (ORCPT ); Thu, 22 Apr 2021 12:13:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AFE77613FA; Thu, 22 Apr 2021 16:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619107961; bh=StivcVD9xXu0rWnliGlK3Di9LBDcwLdEvblI2w8R7OM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LqZlGEbuM6/TYtsddHzWNpv36nTueJY4ONSELqRugx9Rgkmb62aoGknxJuFj1K81o L2MjJKkoNaS83JMzkN4kfTtjWgdmcac2ZINLJazYAr9eWwRC43Rp8jWq8Jx2ZV9B0C VMsMugEgCvT+Wp5Qg1HuNYg6I4iUJ3p1MRsPk6ITCK+CBvJZ+9fpGqieNNMzhQ0SBg MgJWx8hRiuym2vygfMs/yTnUsL/AWKWjLFm+bq7/cCRLjt+DuIJzC3ZRTaGzeZ7Lc8 sgZ+C+SsId/LlpV9Ih32OYwQBxRxM/T/yGA/fueHe3P2i/0hAeyUFfgMHxNm7XhWX/ M9FWcEL1YvG6g== Date: Thu, 22 Apr 2021 09:12:41 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Dan Williams , Vivek Goyal , Greg Kurz , linux-fsdevel , Jan Kara , Matthew Wilcox , linux-nvdimm , Miklos Szeredi , Linux Kernel Mailing List , virtio-fs-list Subject: Re: [Virtio-fs] [PATCH v3 2/3] dax: Add a wakeup mode parameter to put_unlocked_entry() Message-ID: <20210422161241.GC547183@magnolia> References: <20210419213636.1514816-1-vgoyal@redhat.com> <20210419213636.1514816-3-vgoyal@redhat.com> <20210420093420.2eed3939@bahia.lan> <20210420140033.GA1529659@redhat.com> <20210422062458.GA4176641@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422062458.GA4176641@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 07:24:58AM +0100, Christoph Hellwig wrote: > On Wed, Apr 21, 2021 at 12:09:54PM -0700, Dan Williams wrote: > > Can you get in the habit of not replying inline with new patches like > > this? Collect the review feedback, take a pause, and resend the full > > series so tooling like b4 and patchwork can track when a new posting > > supersedes a previous one. As is, this inline style inflicts manual > > effort on the maintainer. > > Honestly I don't mind it at all. If you shiny new tooling can't handle > it maybe you should fix your shiny new tooling instead of changing > everyones workflow? Just speaking for XFS here, but I don't like inline resubmissions because that makes it /really/ hard to find the original patch 6 months later when everything has paged out of my brain but random enterprise distro backporters start asking questions ("is this an actively exploited security fix?" "what were you smoking?" etc). At least change the subject line to something that screams "new patch!" so that mutt and lore will make it stand out. (Granted this isn't XFS, so I am not the enforcer here ;)) --D