From: Ben Dai <ben.dai9703@gmail.com>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Ben Dai <ben.dai@unisoc.com>
Subject: [PATCH] genirq/timings: prevent potential array overflow in __irq_timings_store()
Date: Sun, 25 Apr 2021 23:09:03 +0800 [thread overview]
Message-ID: <20210425150903.25456-1-ben.dai9703@gmail.com> (raw)
From: Ben Dai <ben.dai@unisoc.com>
When the interrupt interval is greater than 2 ^ PREDICTION_BUFFER_SIZE *
PREDICTION_FACTOR us and less than 1s, the calculated index will be greater
than the length of irqs->ema_time[]. Check the calculated index before
using it to prevent array overflow.
Signed-off-by: Ben Dai <ben.dai@unisoc.com>
---
kernel/irq/timings.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
index 773b6105c4ae..6990490fa67b 100644
--- a/kernel/irq/timings.c
+++ b/kernel/irq/timings.c
@@ -453,6 +453,11 @@ static __always_inline void __irq_timings_store(int irq, struct irqt_stat *irqs,
*/
index = irq_timings_interval_index(interval);
+ if (index > PREDICTION_BUFFER_SIZE - 1) {
+ irqs->count = 0;
+ return;
+ }
+
/*
* Store the index as an element of the pattern in another
* circular array.
--
2.25.1
next reply other threads:[~2021-04-25 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 15:09 Ben Dai [this message]
2021-08-10 13:41 ` [tip: irq/urgent] genirq/timings: Prevent " tip-bot2 for Ben Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210425150903.25456-1-ben.dai9703@gmail.com \
--to=ben.dai9703@gmail.com \
--cc=ben.dai@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®