From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC331C433ED for ; Mon, 26 Apr 2021 11:03:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9309F60FE8 for ; Mon, 26 Apr 2021 11:03:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233074AbhDZLEG (ORCPT ); Mon, 26 Apr 2021 07:04:06 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:50328 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232878AbhDZLD7 (ORCPT ); Mon, 26 Apr 2021 07:03:59 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 9FDB21C0B77; Mon, 26 Apr 2021 13:03:16 +0200 (CEST) Date: Mon, 26 Apr 2021 13:03:16 +0200 From: Pavel Machek To: Tianling Shen Cc: Heiko Stuebner , Marty Jones , Rob Herring , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jensen Huang , Jacek Anaszewski , Geert Uytterhoeven , David Bauer , Johan Jonker , Jagan Teki , Chen-Yu Tsai , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/Rockchip SoC..." , Linux ARM Subject: Re: [PATCH v6 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S Message-ID: <20210426110316.GA13974@duo.ucw.cz> References: <20210319051627.814-1-cnsztl@gmail.com> <161640742725.808893.3666594351389773587.b4-ty@sntech.de> <20210425213321.GF10996@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > > - Fixed format of LED nodes > > > > > > > > Changes in v5: > > > > - Dropped the empty PCIe node > > > > - Dropped useless `/delete-property/` > > > > - Renamed LED nodes > > > > > > > > [...] > > > > > > Applied, thanks! > > > > > > [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S > > > commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48 > > > [2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S > > > commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992 > > > > Sorry for late review, but: > > > > > > + label =3D "red:sys"; > > > > This should be red:power based on the discussion in earlier threads. >=20 > However based on the introduction from FriendlyELEC[1], this is not > the "power" lamp... > "LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)" It is always on, and "sys" is not a valid function. I'd suggest labeling it as "red:power". Feel free to make other suggestion but lets keep existing functions. Pavel --=20 http://www.livejournal.com/~pavelmachek --huq684BweRXVnRxX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYIad9AAKCRAw5/Bqldv6 8rTHAJ4nA4Fv8pKz5+41IbOTLBjIMzKo5wCgniy+wweKJ3Bq1M+lSS+ghFLC/5A= =/ktb -----END PGP SIGNATURE----- --huq684BweRXVnRxX--