From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D05C433B4 for ; Mon, 26 Apr 2021 11:11:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 297C061249 for ; Mon, 26 Apr 2021 11:11:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233147AbhDZLMF (ORCPT ); Mon, 26 Apr 2021 07:12:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232185AbhDZLMC (ORCPT ); Mon, 26 Apr 2021 07:12:02 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D5B3C061574 for ; Mon, 26 Apr 2021 04:11:20 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id e5so26774475wrg.7 for ; Mon, 26 Apr 2021 04:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uXYb6BcHq27B6ScYW5tJ2SsqBaNuDx8oA92+GxjafKM=; b=xvUi/jFjSPOSvlz/BbBKn+ZE/Z9NzwrofgB+eXRzJYQ/2bL+Zb/2VVGEt/iCzyPK98 pL/9abpx2tk1hTgBG+JZESktFflsU17VR7wROE4/rrO1Cn4RyLqRP1YUNglHucbWC8S6 FOapPgutJJ9vKG0pgRhXNA4OuWK2cYA8x6XrJoQw07n1tJk9I5G+861+X0/z3Trj8pJQ kkaZljXTsrsuiVJKyTtS7854orFz2eynPNELr27p9eMBR751mXIJXN/tFyxP64DI+96A lCIcVSZgqJU9/c/usNiOESCKyIqI0DPDeryvlUzWHzdJyWfA9xJBsAnXo+zYDj1Y+++L tx8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uXYb6BcHq27B6ScYW5tJ2SsqBaNuDx8oA92+GxjafKM=; b=KbSEbeur7qvazp58U264CIrvkU1lW08P5o++itt+UCzmOUBwmon03gj5jMo9iv2bqe kukBklAWmAR7sWDkroU5AngD+P3J2v9j2AibPjpQkTtyRKx6+SgnhHghF70+kj4rjcl1 yMmsZzla1fGGZ7LEwkV5UVZq3EhfQpFuMdIu+hnteDAEY5Nnl6VY6sZh/XfH08sIg7FI oSrvxqXqFnkVAvuLy0DOoWq79rWg+emGLJAWVCRWso9MjV9Zbj1PT+CWzKJ+6sdmqUAZ /WkiiaLmXhBn5FwMaV9mH8A+6rQOr90OGvKZdHcZHXaANk/XhJl3YeAFsHQvqk0ACyVY KOsg== X-Gm-Message-State: AOAM532l/qrTkiy2yC1bB7lK1LW3w6uPTwswYhk4HLNENx2RNSIzBRyl reej6McU8KgjV03LMTBdxmkddw== X-Google-Smtp-Source: ABdhPJzthkQ8A9dbPXyiOrcJp3qKrnW8BYa16c26OInVfMwwDZA1oulOtgOaJrtr56/7q3TzEzs6yw== X-Received: by 2002:adf:d1c3:: with SMTP id b3mr22233136wrd.367.1619435478756; Mon, 26 Apr 2021 04:11:18 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id t20sm19529761wmi.35.2021.04.26.04.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 04:11:18 -0700 (PDT) Date: Mon, 26 Apr 2021 12:11:16 +0100 From: Daniel Thompson To: Rajeev Nandan Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, mkrishn@codeaurora.org, linux-kernel@vger.kernel.org, abhinavk@codeaurora.org, dianders@chromium.org, seanpaul@chromium.org, kalyan_t@codeaurora.org, hoegsberg@chromium.org, Lyude Paul , Jani Nikula Subject: Re: [v2 2/2] backlight: Add DisplayPort aux backlight driver Message-ID: <20210426111116.4lc3ekxjugjr3oho@maple.lan> References: <1619214904-10218-1-git-send-email-rajeevny@codeaurora.org> <1619214904-10218-3-git-send-email-rajeevny@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619214904-10218-3-git-send-email-rajeevny@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 24, 2021 at 03:25:04AM +0530, Rajeev Nandan wrote: > Add backlight driver for the panels supporting backlight control > using DPCD registers on the DisplayPort aux channel. > > Changes in v2: > - New (most of the code reused from drm_dp_aux_backlight.c of v1) Did you respond to Jani's feedback on the v1 posting (asking you to coordinate with Lyude's work on refactoring the i915 eDP helpers[1])? I can't find anything showing the outcome of that. [1]: https://www.spinics.net/lists/dri-devel/msg295602.html > +static struct drm_dp_aux *i2c_to_aux(struct i2c_adapter *i2c) > +{ > + return container_of(i2c, struct drm_dp_aux, ddc); > +} [...] > + np = of_parse_phandle(pdev->dev.of_node, "ddc-i2c-bus", 0); > + if (!np) { > + dev_err(&pdev->dev, "failed to get aux ddc I2C bus\n"); > + return -ENODEV; > + } > + > + ddc = of_find_i2c_adapter_by_node(np); > + of_node_put(np); > + if (!ddc) > + return -EPROBE_DEFER; > + > + aux_bl->aux = i2c_to_aux(ddc); > + dev_dbg(&pdev->dev, "using dp aux %s\n", aux_bl->aux->name); It looks like this code "just knows" that the I2C controller it has looked up is a special one. That seems a little odd to me. If we "just know" this then I'd hope that is could either be modelled in the devicetree or that it would be possible for the backlight driver to be registered (possibly using helpers) by whatever it is that is setting up struct drm_dp_aux in the first place. Daniel.