From: Jules Irenge <jbi.octave@gmail.com>
To: rcu@vger.kernel.org
Cc: joel@joelfernandes.org, jiangshanlai@gmail.com,
mathieu.desnoyers@efficios.com, rostedt@goodmis.org,
paulmck@kernel.org, linux-kernel@vger.kernel.org,
Jules Irenge <jbi.octave@gmail.com>
Subject: [PATCH] rcu: Add missing __releases() annotation
Date: Thu, 29 Apr 2021 00:12:19 +0100 [thread overview]
Message-ID: <20210428231219.48109-1-jbi.octave@gmail.com> (raw)
Sparse report a warning at rcu_print_task_stall()
"warning: context imbalance in rcu_print_task_stall - unexpected unlock"
The root cause is a missing annotation at rcu_print_task_stall() function
Add the missing __releases(rnp->lock) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
kernel/rcu/tree_stall.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h
index 59b95cc5cbdf..18b2d5274d65 100644
--- a/kernel/rcu/tree_stall.h
+++ b/kernel/rcu/tree_stall.h
@@ -314,6 +314,7 @@ static void rcu_print_detail_task_stall_rnp(struct rcu_node *rnp)
* tasks blocked within RCU read-side critical sections.
*/
static int rcu_print_task_stall(struct rcu_node *rnp, unsigned long flags)
+ __releases(rnp->lock)
{
raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
return 0;
--
2.31.1
next reply other threads:[~2021-04-28 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 23:12 Jules Irenge [this message]
2021-04-29 18:39 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428231219.48109-1-jbi.octave@gmail.com \
--to=jbi.octave@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®