From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 351F5C433B4 for ; Thu, 29 Apr 2021 16:44:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3D3761453 for ; Thu, 29 Apr 2021 16:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240824AbhD2QpW (ORCPT ); Thu, 29 Apr 2021 12:45:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:59870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232724AbhD2QpU (ORCPT ); Thu, 29 Apr 2021 12:45:20 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A230D6143B; Thu, 29 Apr 2021 16:44:32 +0000 (UTC) Date: Thu, 29 Apr 2021 12:44:30 -0400 From: Steven Rostedt To: "Fabio M. De Francesco" Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched: Replace 'unsigned' with 'unsigned int' Message-ID: <20210429124430.5755dca8@gandalf.local.home> In-Reply-To: <20210429122454.9936-1-fmdefrancesco@gmail.com> References: <20210429122454.9936-1-fmdefrancesco@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Apr 2021 14:24:54 +0200 "Fabio M. De Francesco" wrote: > Replaced 'unsigned' with 'unsigned int' because the second is preferred. > Detected by checkpatch.pl. Please do not fix existing code because of "preferred" coding style from checkpatch.pl. It causes unnecessary churn, and a waste of time applying it. "unsigned" is just as good as "unsigned int" , and honestly, that's what I prefer. NACK. -- Steve